Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(website): load typescript libs in playground#4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomainfromfix/website-play-libs
Mar 31, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMar 30, 2022•
edited
Loading

PR Checklist

Overview

Logic used to load requested libs from cdn and parse them in compiler

Repro

PlaygroundPlayground 2

this solution is not ideal, as libs are loaded once during editor initialization and can't be changed without reload, for now this is not an issue as there is no way to specify libs

note: dynamic typescript config is and was not taken into account in eslint, this should be adjusted in latter PR

@armano2armano2 added the package: websiteIssues related to the @typescript-eslint website labelMar 30, 2022
@nx-cloud
Copy link

nx-cloudbot commentedMar 30, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit271530a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint

This comment was marked as resolved.

@armano2armano2 changed the titlefix(website): load typescript libs in playground #4493fix(website): load typescript libs in playgroundMar 30, 2022
@netlify
Copy link

netlifybot commentedMar 30, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit271530a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6244d9713d3f70000853de4a
😎 Deploy Previewhttps://deploy-preview-4765--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 self-assigned thisMar 30, 2022
@armano2armano2 requested review frombradzacher and removed request forbradzacherMarch 30, 2022 21:13
);
export function createASTProgram(code, isJsx, compilerOptions, libs) {
const fileName = isJsx ? '/demo.tsx' : '/demo.ts';
const compilerHost = new CompilerHost(libs, isJsx);
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ideally we would like to use watch compiler host, but that can come latter

@armano2armano2force-pushed thefix/website-play-libs branch from3f06d47 to271530aCompareMarch 30, 2022 22:27
@armano2armano2 removed their assignmentMar 31, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As an aside - should we be convertingwebsite-eslint to TS? Seems like we're adding more and more code, so the safety would probably be a good thing to have.

LGTM - thanks so much for working and fixing this!
This is a huge win for setting up issue repros!

@bradzacherbradzacher changed the titlefix(website): load typescript libs in playgrounddocs(website): load typescript libs in playgroundMar 31, 2022
@bradzacherbradzacher merged commitc59d9d7 intomainMar 31, 2022
@bradzacherbradzacher deleted the fix/website-play-libs branchMarch 31, 2022 19:30
@bradzacher
Copy link
Member

Hmmm@armano2 - it looks like this didn't quite fix it.

https://typescript-eslint.io/play/#ts=4.6.2&sourceType=module&code=CYUwxgNghgTiAEAzArgOzAFwJYHtXwDcctgB5GABRhwFssBnEAClgHMAueJpgSngF4AfIWLA+AHy68BwqrQYgAPERKCePTiuABuIA&rules=N4XyA&tsConfig=N4XyA

Cannot find name 'Promise'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2015' or later.(2583)

@bradzacher
Copy link
Member

Super strange! I'm not sure why the two environments would differ!

@armano2
Copy link
CollaboratorAuthor

armano2 commentedMar 31, 2022•
edited
Loading

ok i found issue,setCompilerSettings is not playing well withlib option, this was introduced in
https://github.com/typescript-eslint/typescript-eslint/pull/4768/files#diff-33270f45a22222a850f0e991bf7064abddec50370ec23ec17049010a272d72f7R146

I'm going to submit PR with this

@armano2
Copy link
CollaboratorAuthor

armano2 commentedApr 2, 2022•
edited
Loading

As an aside - should we be convertingwebsite-eslint to TS? Seems like we're adding more and more code, so the safety would probably be a good thing to have.

@bradzacher generally i will like to get rid of js code from this package, and move weblinter to website, initially i created it to process eslint, typescript and tseslint to version usable by browser, but it grew a little, when i find some time i'm going to to some refactoring, but for now my work is keeping me to "bussy"

bradzacher reacted with heart emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 23, 2022
@armano2armano2 self-assigned thisMay 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

@armano2armano2

Labels
package: websiteIssues related to the @typescript-eslint website
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground: incorrect type causing false negatives
2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp