typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

docs(website): filter out spam and add non-recurring donors#4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromJoshuaKGoldberg:sponsors-filter-expand

Apr 14, 2022

Merged

docs(website): filter out spam and add non-recurring donors#4758

JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromJoshuaKGoldberg:sponsors-filter-expand

Apr 14, 2022

Conversation

Copy link

Member

JoshuaKGoldberg commentedMar 28, 2022•
edited by JamesHenry
Loading

PR Checklist

Addresses an existing issue:fixesDocs: Website sponsor data includes low-donation spam #4757
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Updates thegenerate-sponsors.ts task file to merge OpenCollective data from two sources:

account: retrieves all orders given to us
collective: retrieves collected individual member data, including their total donation count

Splits the displayed data into three tiers:

Sponsor: Donors of $750 or more, and/or a monthly amount of $100 or more
Gold Supporter: Donors of $150 or more, and/or a monthly amount of $3 or more
Supporter: Donors of $50 or more

docs(website): filter out spam and add non-recurring donors

0cb659e

Copy link

nx-cloudbot commentedMar 28, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita4af58b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedMar 28, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`a4af58b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62574208ceef1900090db87f
😎 Deploy Preview	https://deploy-preview-4758--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

Contributor

typescript-eslintbot commentedMar 28, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

JoshuaKGoldberg commented

Mar 28, 2022

View reviewed changes

packages/website/src/components/FinancialContributors.tsx OutdatedShow resolvedHide resolved

chore: updated to remove links at lower tiers, with pending data migr…

3ecf48e

…ation

JoshuaKGoldberg mentioned this pull request

Apr 4, 2022

chore: update sponsors#4782

Closed

JoshuaKGoldberg added2 commits

April 8, 2022 13:10

chore: updated to have URLs in supporters

28b1dfb

Merge branch 'main' into sponsors-filter-expand

113ec1e

JoshuaKGoldberg commented

Apr 8, 2022

View reviewed changes

packages/website/src/components/FinancialContributors/index.tsx OutdatedShow resolvedHide resolved

JoshuaKGoldberg added2 commits

April 8, 2022 13:14

chore: adjusted slug for todo

aedd6b7

Merge branch 'sponsors-filter-expand' ofhttps://github.com/JoshuaKGo…

7614dda

…ldberg/typescript-eslint into sponsors-filter-expand

JoshuaKGoldberg marked this pull request as ready for review

April 8, 2022 17:15

JoshuaKGoldberg requested review frombradzacher andJamesHenry

April 8, 2022 17:15

bradzacher added the documentationDocumentation ("docs") that needs adding/updating label

Apr 8, 2022

bradzacher reviewed

Apr 8, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nitpick - one dangling "contributor" is rendered.

Do we want to "cap" the number of avatars shown?

I.e. we could just show the first 22 to fill out 2 lines.
Or we could dynamically show more lines but only show a new line if there's a nice amount like:

minPerLine = ???; // maybe 4?numToShow = count;if (count % 11 < minPerLine) {  numToShow = count - (count % 11);}

packages/website/src/components/FinancialContributors/index.tsx OutdatedShow resolvedHide resolved

bradzacher previously approved these changes

Apr 9, 2022

View reviewed changes

bradzacher mentioned this pull request

Apr 11, 2022

chore: update sponsors#4801

Closed

chore: rename to 'Gold' Supporter

a13e1e0

JoshuaKGoldberg dismissedbradzacher’sstale review viaa13e1e0

April 13, 2022 00:04

JoshuaKGoldberg commented

Apr 13, 2022

View reviewed changes

tools/generate-sponsors.ts

		'Florian Studio',
		'java',
		'Loyalty Leo',
		'Penalty.com',

Copy link

MemberAuthor

JoshuaKGoldbergApr 13, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#4758 (review)

@bradzacher that one trailing box is really irritating, isn't it? 😄

OpenCollective support said they'd stop the spam, but these accounts are still showing up.

Copy link

Member

bradzacher commentedApr 13, 2022

screen-20220412-232950.3.mp4

Checking on mobile (pixel 4) - the layout doesn't respect the thinner width properly.

But looks good on a desktop (or desktop view on mobile lol)

JoshuaKGoldberg added2 commits

April 13, 2022 17:33

fix: mobile responsiveness for sponsors

257e5d6

Merge branch 'main' into sponsors-filter-expand

a4af58b

Copy link

MemberAuthor

JoshuaKGoldberg commentedApr 13, 2022

Grr, should be fixed now.

Copy link

codecovbot commentedApr 13, 2022•
edited
Loading

Codecov Report

Merging#4758 (a4af58b) intomain (18a81cb) willincrease coverage by0.31%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4758      +/-   ##==========================================+ Coverage   93.96%   94.27%   +0.31%==========================================  Files         172      151      -21       Lines        9818     8220    -1598       Branches     3105     2672     -433     ==========================================- Hits         9225     7749    -1476+ Misses        353      262      -91+ Partials      240      209      -31

Flag	Coverage Δ
unittest	`94.27% <ø> (+0.31%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...estree/src/create-program/createIsolatedProgram.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/convert-comments.ts
...ript-estree/src/create-program/createSourceFile.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/node-utils.ts
...-internal/src/rules/no-typescript-estree-import.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/simple-traverse.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
... and11 more