Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now#4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Reverts#4710. 😢

@bradzacher I was so hopeful about it too..

@nx-cloud
Copy link

nx-cloudbot commentedMar 26, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commited5506e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 41 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMar 26, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commited5506e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/623f9d698ce0410009590abb
😎 Deploy Previewhttps://deploy-preview-4740--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher
bradzacher previously approved these changesMar 26, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess there's some things we need to update manually first?

@JoshuaKGoldbergJoshuaKGoldberg changed the titleRevert "chore: Bump cypress from 8.3.0 to 9.5.2"Revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for nowMar 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg changed the titleRevert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for nowfix: revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for nowMar 26, 2022
@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)March 26, 2022 23:10
@JoshuaKGoldberg
Copy link
MemberAuthor

Yeah, once the outstanding Cypress issues about flake in CI are resolved I think we can try this again.

@codecov
Copy link

codecovbot commentedMar 26, 2022
edited
Loading

Codecov Report

Merging#4740 (ed5506e) intomain (9707daa) willincrease coverage by0.57%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4740      +/-   ##==========================================+ Coverage   92.06%   92.63%   +0.57%==========================================  Files         355      317      -38       Lines       12097    11698     -399       Branches     3455     3415      -40     ==========================================- Hits        11137    10837     -300+ Misses        630      561      -69+ Partials      330      300      -30
FlagCoverage Δ
unittest92.63% <ø> (+0.57%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/utils/src/ast-utils/helpers.ts
packages/utils/src/ts-eslint/ESLint.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
packages/utils/src/eslint-utils/deepMerge.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/visitor-keys/src/get-keys.ts
packages/utils/src/ts-eslint/Scope.ts
packages/utils/src/eslint-utils/applyDefault.ts
.../utils/src/ast-utils/eslint-utils/scopeAnalysis.ts
packages/utils/src/ast-utils/eslint-utils/index.ts
... and28 more

@JoshuaKGoldbergJoshuaKGoldberg merged commitcf5f5c4 intomainMar 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the revert-4710-dependabot/npm_and_yarn/cypress-9.5.2 branchMarch 26, 2022 23:25
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp