Adds a new'strict' level for therecommended metadata for rules. It indicates to include the rule in a newplugin:@typescript-eslint/strict config.

~~Putting this PR up now as a draft as reference for#4648 before fleshing out docs.~~ ✅

JoshuaKGoldberg added2 commits

March 21, 2022 10:08

feat: add new 'strict' config

7b05b84

chore: simplified strict to always be 'warn'

418577c

Copy link

nx-cloudbot commentedMar 21, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitbe77517. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMar 21, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedMar 21, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`be77517`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62818e854c97ba00084a725e
😎 Deploy Preview	https://deploy-preview-4706--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Merge branch 'main' into strict-config

792c751

JoshuaKGoldberg mentioned this pull request

Mar 21, 2022

Create a "strict" config between "recommended-requiring-type-checking" and "all"#4648

Closed

JoshuaKGoldberg added4 commits

March 21, 2022 10:52

chore: missing | false

c17ad3e

test: update tests for new strictness

1707478

test: update .md file templates and docs.test.ts

9c0dbd6

chore: update configs.test.ts too

d741d55

Copy link

codecovbot commentedApr 4, 2022•
edited
Loading

Codecov Report

Merging#4706 (be77517) intomain (77e15a9) willincrease coverage by1.44%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4706      +/-   ##==========================================+ Coverage   92.64%   94.08%   +1.44%==========================================  Files         190      161      -29       Lines       10251     8559    -1692       Branches     3249     2770     -479     ==========================================- Hits         9497     8053    -1444+ Misses        502      285     -217+ Partials      252      221      -31

Flag	Coverage Δ
unittest	`94.08% <100.00%> (+1.44%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts	`97.18% <ø> (ø)`
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-types.ts	`100.00% <ø> (ø)`
...t-plugin/src/rules/class-literal-property-style.ts	`100.00% <ø> (ø)`
...lugin/src/rules/consistent-indexed-object-style.ts	`92.06% <ø> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`88.88% <ø> (ø)`
...nt-plugin/src/rules/consistent-type-definitions.ts	`97.29% <ø> (ø)`
packages/eslint-plugin/src/rules/dot-notation.ts	`96.29% <ø> (ø)`
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`98.41% <ø> (ø)`
...lugin/src/rules/no-confusing-non-null-assertion.ts	`82.60% <ø> (ø)`
... and57 more

JoshuaKGoldberg added3 commits

April 3, 2022 20:01

Merge branch 'main' into strict-config

903247f

chore: update website docs

b237870

Merge branch 'main' into strict-config

a4a7c45

JoshuaKGoldberg marked this pull request as ready for review

April 8, 2022 17:43

bradzacher added the recommended-rulesDiscussion about recommended rule sets label

Apr 8, 2022

bradzacher previously approved these changes

Apr 9, 2022

View reviewed changes

docs/linting/PRESETS.md OutdatedShow resolvedHide resolved

packages/eslint-plugin/docs/rules/TEMPLATE.md OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/configs/strict.tsShow resolvedHide resolved

JoshuaKGoldberg mentioned this pull request

Apr 12, 2022

[eslint-plugin] Breaking: enable type information for prefer-optional-chain#4820

Closed

JoshuaKGoldberg added2 commits

April 12, 2022 19:19

docs: add sub-list of configs to attributes

5131919

docs: unified configs readme and presets file

51b19d2

JoshuaKGoldberg dismissedbradzacher’sstale review via5131919

April 12, 2022 23:20

JoshuaKGoldberg mentioned this pull request

Apr 12, 2022

Add new issue template for changing recommended configs#4822

Closed

JoshuaKGoldberg added5 commits

April 12, 2022 19:41

Merge branch 'main'

cc23e5f

docs: finish trimming configs readme

48d7225

fix: sidebar.base.js

c9d67dc

fix: finish renaming presets to config

a5134bd

fix: configs docs id

009bc6d

JoshuaKGoldberg requested review frombradzacher andarmano2

April 13, 2022 01:22

JoshuaKGoldberg added2 commits

April 12, 2022 21:23

fix: typo; not 'three'

789cab6

fix: tip colons

d577332

JoshuaKGoldberg mentioned this pull request

Apr 17, 2022

[no-unreachable] and [no-unused-label] are handled inconsistently#4819

Closed

3 tasks

bradzacher previously approved these changes

Apr 18, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

bradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Apr 22, 2022

JoshuaKGoldberg changed the title~~feat: add new 'strict' config~~feat(eslint-plugin): add new 'strict' config

May 15, 2022

JoshuaKGoldberg commented

May 15, 2022

View reviewed changes

packages/eslint-plugin/docs/rules/TEMPLATE.md OutdatedShow resolvedHide resolved

JoshuaKGoldberg added2 commits

May 15, 2022 15:31

chore: replace heavy_check_mark with lock

3bebc55

Merge branch 'main'

3e8ed85

JoshuaKGoldberg dismissedbradzacher’sstale review via3e8ed85

May 15, 2022 19:37

bradzacher previously approved these changes

May 15, 2022

View reviewed changes

Copy link

Member

bradzacher commentedMay 15, 2022

feel free to admin merge once you've got this finalised - i'm happy with what you've got!

chore: mostly fixed up docs, probably one or two more things to do

0fe329e

JoshuaKGoldberg dismissedbradzacher’sstale review via0fe329e

May 15, 2022 22:54

Copy link

MemberAuthor

JoshuaKGoldberg commentedMay 15, 2022

My main hesitation against pushing this is that we don't have a blog to nicely announce it on yet (#4957) 😂. But that's not a good reason. We can always posthumously write a blog post for this PR.

JoshuaKGoldberg added3 commits

May 15, 2022 19:19

docs: method-signature-style period, more in configs.ts

9f9921c

docs: method-signature-style period, more in configs.ts; fix readmes

aa469d2

chore: passing configs.test.ts, docs.test.ts locally

be77517

JoshuaKGoldberg merged commit4a500b2 intotypescript-eslint:main

May 16, 2022

JoshuaKGoldberg deleted the strict-config branch

May 16, 2022 00:09

JoshuaKGoldberg mentioned this pull request

May 17, 2022

Bug: resolvingbase config errors when enabling newstrict preset#5001

Closed

4 tasks

JoshuaKGoldberg commented

May 17, 2022

View reviewed changes

packages/eslint-plugin/tools/generate-configs.ts

		extends: [
		...EXTENDS,
		'./configs/recommended',
		'./configs/recommended-requiring-type-checking',

Copy link

MemberAuthor

JoshuaKGoldbergMay 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh hey I think I'd meant to leave this out.

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

May 19, 2022

Update typescript-eslint monorepo to v5.25.0 (#1357)

39823e2

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.23.0/5.25.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.23.0/5.25.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17)[Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0)##### Bug Fixes-   **eslint-plugin:** \[typedef] stop enforcing rule for assignment expressions ([#&#8203;4958](typescript-eslint/typescript-eslint#4958)) ([04a216c](typescript-eslint/typescript-eslint@04a216c))-   **eslint-plugin:** strict config should not extend recommended ([#&#8203;5005](typescript-eslint/typescript-eslint#5005)) ([05d71c2](typescript-eslint/typescript-eslint@05d71c2))-   **website:** correct Presets link to be Configs ([#&#8203;5004](typescript-eslint/typescript-eslint#5004)) ([e18e91c](typescript-eslint/typescript-eslint@e18e91c))##### Features-   **eslint-plugin:** \[no-empty-function] new allow option overrideMethods ([#&#8203;4923](typescript-eslint/typescript-eslint#4923)) ([13c05ae](typescript-eslint/typescript-eslint@13c05ae))-   **eslint-plugin:** deprecate `no-duplicate-imports` in favour of `import/no-duplicates` ([#&#8203;4973](typescript-eslint/typescript-eslint#4973)) ([1d2e41a](typescript-eslint/typescript-eslint@1d2e41a))-   update to TypeScript 4.7-rc ([#&#8203;4829](typescript-eslint/typescript-eslint#4829)) ([6fe783c](typescript-eslint/typescript-eslint@6fe783c))### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16)[Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0)##### Bug Fixes-   **eslint-plugin:** \[array-type] in fixer add missing parens for constructor types [#&#8203;4756](typescript-eslint/typescript-eslint#4756) ([#&#8203;4971](typescript-eslint/typescript-eslint#4971)) ([0377070](typescript-eslint/typescript-eslint@0377070))##### Features-   **eslint-plugin:** Add BigInt object type to default ban-types list ([#&#8203;4970](typescript-eslint/typescript-eslint#4970)) ([1867728](typescript-eslint/typescript-eslint@1867728))-   **eslint-plugin:** add new 'strict' config ([#&#8203;4706](typescript-eslint/typescript-eslint#4706)) ([4a500b2](typescript-eslint/typescript-eslint@4a500b2))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17)[Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16)[Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1357Reviewed-by: 6543 <6543@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>