Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-misused-promises] add granular options withinchecksVoidReturns#4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMar 2, 2022•
edited
Loading

PR Checklist

Overview

Allows user configurations to provide an object containing opt-outs for:

interfaceChecksVoidReturnOptions{arguments?:boolean;attributes?:boolean;properties?:boolean;returns?:boolean;variables?:boolean;}

Specifically thearguments one should be useful for folks#4619. Folks who don't mind passing a() => Promise<void> to a() => void handler, such as React button clicks, can disable it with:

{"@typescript-eslint/no-misused-promises": ["error",    {"checksVoidReturn": {"arguments":false      }    }  ]}

...though we should note per#4619 (comment) that doing so is silencing a legitimate report about a misused promise. The "proper" (safe) behavior would be to create some kind ofwrapAsyncFunction as mentioned in#4619 (comment).

lgenzelis reacted with rocket emoji
@nx-cloud
Copy link

nx-cloudbot commentedMar 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commitf921726. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMar 2, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:f921726

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/6220937dfdccad0007adc498

@JoshuaKGoldbergJoshuaKGoldbergforce-pushed theno-misused-promises-void-return-options branch from4dd32ef to7f8a1c2CompareMarch 2, 2022 18:43
@bradzacherbradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labelMar 2, 2022
@JoshuaKGoldbergJoshuaKGoldberg changed the titleNo misused promises void return options[no-misused-promises] add opt-opt options within checksVoidReturnsMar 2, 2022
@codecov
Copy link

codecovbot commentedMar 2, 2022•
edited
Loading

Codecov Report

Merging#4623 (f921726) intomain (fabfc2b) willincrease coverage by1.82%.
The diff coverage is97.77%.

@@            Coverage Diff             @@##             main    #4623      +/-   ##==========================================+ Coverage   92.41%   94.23%   +1.82%==========================================  Files         350      151     -199       Lines       12059     7948    -4111       Branches     3430     2572     -858     ==========================================- Hits        11144     7490    -3654+ Misses        642      262     -380+ Partials      273      196      -77
FlagCoverage Δ
unittest94.23% <97.77%> (+1.82%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts97.14% <92.85%> (-0.16%)⬇️
...ges/eslint-plugin/src/rules/no-misused-promises.ts98.24% <97.29%> (-0.40%)⬇️
...gin/src/rules/naming-convention-utils/validator.ts94.96% <100.00%> (-0.55%)⬇️
...es/eslint-plugin/src/rules/prefer-function-type.ts97.14% <100.00%> (-0.05%)⬇️
...es/eslint-plugin/src/util/getOperatorPrecedence.ts31.42% <0.00%> (-28.58%)⬇️
.../src/rules/sort-type-union-intersection-members.ts90.74% <0.00%> (-1.80%)⬇️
...ackages/eslint-plugin/src/rules/no-invalid-this.ts78.26% <0.00%> (-1.74%)⬇️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts81.25% <0.00%> (-1.45%)⬇️
...s/eslint-plugin/src/rules/no-implicit-any-catch.ts83.33% <0.00%> (-1.29%)⬇️
.../eslint-plugin/src/rules/method-signature-style.ts87.65% <0.00%> (-1.24%)⬇️
... and301 more

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMarch 2, 2022 19:31
@JoshuaKGoldberg
Copy link
MemberAuthor

👋@uhyo, just a heads up following#4541

uhyo reacted with thumbs up emojiuhyo reacted with laugh emojiuhyo reacted with heart emoji

@bradzacherbradzacher changed the title[no-misused-promises] add opt-opt options within checksVoidReturnsfeat(eslint-plugin): [no-misused-promises] add opt-opt options within checksVoidReturnsMar 2, 2022
bradzacher
bradzacher previously approved these changesMar 3, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

implementation looks good - just one comment around documentation

@uhyo
Copy link
Contributor

uhyo commentedMar 3, 2022

Sorry, I should have considered adding those options from start. Thank you for follow-up! 😄

JoshuaKGoldberg and lgenzelis reacted with heart emoji

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

NOICE

@bradzacherbradzacher changed the titlefeat(eslint-plugin): [no-misused-promises] add opt-opt options within checksVoidReturnsfeat(eslint-plugin): [no-misused-promises] add granular options withinchecksVoidReturnsMar 3, 2022
@bradzacherbradzacher merged commit1085177 intotypescript-eslint:mainMar 3, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the no-misused-promises-void-return-options branchMarch 3, 2022 19:21
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestMar 8, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.13.0` -> `5.14.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.13.0/5.14.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.13.0` -> `5.14.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.13.0/5.14.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.14.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5140-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5130v5140-2022-03-07)[Compare Source](typescript-eslint/typescript-eslint@v5.13.0...v5.14.0)##### Bug Fixes-   **eslint-plugin:** \[naming-convention] cover case that requires quotes ([#&#8203;4582](typescript-eslint/typescript-eslint#4582)) ([3ea0947](typescript-eslint/typescript-eslint@3ea0947))-   **eslint-plugin:** \[no-misused-promises] factor thenable returning function overload signatures ([#&#8203;4620](typescript-eslint/typescript-eslint#4620)) ([56a09e9](typescript-eslint/typescript-eslint@56a09e9))-   **eslint-plugin:** \[prefer-readonly-parameter-types] handle class sharp private field and member without throwing error ([#&#8203;4343](typescript-eslint/typescript-eslint#4343)) ([a65713a](typescript-eslint/typescript-eslint@a65713a))-   **eslint-plugin:** \[return-await] correct autofixer in binary expression ([#&#8203;4401](typescript-eslint/typescript-eslint#4401)) ([5fa2fad](typescript-eslint/typescript-eslint@5fa2fad))##### Features-   **eslint-plugin:** \[no-misused-promises] add granular options within `checksVoidReturns` ([#&#8203;4623](typescript-eslint/typescript-eslint#4623)) ([1085177](typescript-eslint/typescript-eslint@1085177))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.14.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5140-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5130v5140-2022-03-07)[Compare Source](typescript-eslint/typescript-eslint@v5.13.0...v5.14.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1201Reviewed-by: 6543 <6543@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-misused-promises] async react callback properties when void expected
3 participants
@JoshuaKGoldberg@uhyo@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp