Splits out the dynamically generated tests fromnaming-convention.test.ts into their own test case files. This lets Jest run them in parallel. There should be no changes to test logic.

Performance runs

Execution:hyperfine -p 'yarn jest --clearCache' --show-output withinpackages/eslint-plugin. Terminal was in focus and no actions taken on open programs during test runs.
Hardware: Surface Laptop 4, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz.
Software: WSL 2.0 in an Ubuntu drive via a VS Code terminal.

Command	`main`	`naming-convention-split`	(old - new) / old x 100%
`yarn jest`	206.237 s ± 3.049 s	174.888 s ± 0.958 s	15% Faster
`yarn jest naming-convention`	120.003 s ± 1.357 s	60.726 s ± 0.911 s	49% Faster

Raw data

yarn jest onmain(reusing time from another PR):

Time (mean ± σ):     206.237 s ±  3.049 s    [User: 1156.814 s, System: 40.173 s]Range (min … max):   201.867 s … 212.914 s    25 runs

yarn jest onnaming-convention-split:

Time (mean ± σ):     174.888 s ±  0.958 s    [User: 1290.055 s, System: 47.218 s]Range (min … max):   173.611 s … 176.374 s    10 runs

yarn jest naming-convention onmain:

Time (mean ± σ):     120.003 s ±  1.357 s    [User: 133.107 s, System: 2.962 s]Range (min … max):   118.722 s … 122.866 s    10 runs

yarn jest naming-convention onnaming-convention-split:

Time (mean ± σ):     60.726 s ±  0.911 s    [User: 436.456 s, System: 13.817 s]Range (min … max):   59.279 s … 62.716 s    10 runs

test: split up naming-convention

4ddfe3d

Copy link

nx-cloudbot commentedFeb 27, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commite866d1a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedFeb 27, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedFeb 27, 2022•
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:e866d1a

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/621e4ab2817ed80008162380

😎 Browse the preview:https://deploy-preview-4599--typescript-eslint.netlify.app

Copy link

codecovbot commentedFeb 27, 2022•
edited
Loading

Codecov Report

Merging#4599 (e866d1a) intomain (fabfc2b) willincrease coverage by1.99%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4599      +/-   ##==========================================+ Coverage   92.41%   94.41%   +1.99%==========================================  Files         350      151     -199       Lines       12059     8229    -3830       Branches     3430     2623     -807     ==========================================- Hits        11144     7769    -3375+ Misses        642      262     -380+ Partials      273      198      -75

Flag	Coverage Δ
unittest	`94.41% <100.00%> (+1.99%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...gin/src/rules/naming-convention-utils/validator.ts	`95.54% <100.00%> (+0.02%)`	⬆️
packages/scope-manager/src/scope/ClassScope.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/visitor-keys/src/visitor-keys.ts
...ges/scope-manager/src/definition/DefinitionType.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
packages/scope-manager/src/lib/esnext.ts
packages/scope-manager/src/lib/es2021.ts
packages/typescript-estree/src/convert-comments.ts
... and190 more