typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

docs: add a missing "#4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromann-kilzer:ann-kilzer-patch-1

Feb 21, 2022

Merged

docs: add a missing "#4577

bradzacher merged 1 commit intotypescript-eslint:mainfromann-kilzer:ann-kilzer-patch-1

Feb 21, 2022

Conversation

Copy link

Contributor

ann-kilzer commentedFeb 20, 2022

PR Checklist

Addresses an existing issue: fixes #000 (NO ISSUE DUE TO SIZE)
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

The documentation is missing a" and I'm trying to fix it.

Happy to file an issue if you think it's worth it, but didn't want to add more noise.

Add a missing "

2bef29c

Copy link

nx-cloudbot commentedFeb 20, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit2bef29c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedFeb 20, 2022

Thanks for the PR,@ann-kilzer!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedFeb 20, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:2bef29c

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/62121e18df5b1c00074a286c

Copy link

codecovbot commentedFeb 20, 2022•
edited
Loading

Codecov Report

Merging#4577 (2bef29c) intomain (b83f597) willdecrease coverage by0.04%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4577      +/-   ##==========================================- Coverage   92.84%   92.79%   -0.05%==========================================  Files         306      163     -143       Lines       11303     8271    -3032       Branches     3300     2654     -646     ==========================================- Hits        10494     7675    -2819+ Misses        546      396     -150+ Partials      263      200      -63

Flag	Coverage Δ
unittest	`92.79% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/lib/es2021.intl.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/lib/webworker.ts
packages/scope-manager/src/lib/es2019.symbol.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
packages/scope-manager/src/lib/es6.ts
.../scope-manager/src/variable/ImplicitLibVariable.ts
packages/scope-manager/src/lib/es2016.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
... and137 more