docs(eslint-plugin): [member-ordering] correct options type#4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromfiahfy:feature/member_ordering

Feb 17, 2022

Merged

docs(eslint-plugin): [member-ordering] correct options type#4568

bradzacher merged 1 commit intotypescript-eslint:mainfromfiahfy:feature/member_ordering

Feb 17, 2022

Conversation

Copy link

Contributor

fiahfy commentedFeb 17, 2022•
edited
Loading

PR Checklist

Addresses an existing issue: fixes #000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Corrected member-ordering options type on the readme.

📝 Update doc for member-ordering options

7b2e28d

Copy link

nx-cloudbot commentedFeb 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit7b2e28d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedFeb 17, 2022

Thanks for the PR,@fiahfy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedFeb 17, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:7b2e28d

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/620e0c2db64f99000793b92a

Copy link

codecovbot commentedFeb 17, 2022•
edited
Loading

Codecov Report

Merging#4568 (7b2e28d) intomain (b83f597) willincrease coverage by1.77%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4568      +/-   ##==========================================+ Coverage   92.84%   94.61%   +1.77%==========================================  Files         306      147     -159       Lines       11303     7912    -3391       Branches     3300     2540     -760     ==========================================- Hits        10494     7486    -3008+ Misses        546      234     -312+ Partials      263      192      -71

Flag	Coverage Δ
unittest	`94.61% <ø> (+1.77%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/lib/es2020.promise.ts
packages/scope-manager/src/ScopeManager.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
packages/scope-manager/src/lib/es2015.core.ts
packages/scope-manager/src/lib/esnext.intl.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/analyze.ts
packages/scope-manager/src/lib/es2017.intl.ts
packages/scope-manager/src/scope/ModuleScope.ts
...ackages/scope-manager/src/lib/es2015.collection.ts
... and149 more