Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): added member group support to member-ordering rule#4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromgrabofus:feat/member-ordering-groupsFeb 24, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
59a1655 feat(eslint-plugin): added member group support to member-ordering rule
grabofus59f96c5 Merge branch 'main' into feat/member-ordering-groups
grabofus13a7c9b test(eslint-plugin): added more test cases for member-ordering
grabofus7988384 test(eslint-plugin): added more test cases for member-ordering
grabofusdf0de90 Merge branch 'main' into feat/member-ordering-groups
JoshuaKGoldbergFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletionspackages/eslint-plugin/docs/rules/member-ordering.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
49 changes: 36 additions & 13 deletionspackages/eslint-plugin/src/rules/member-ordering.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletionspackages/eslint-plugin/tests/rules/member-ordering.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1417,6 +1417,74 @@ class Foo { | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| constructor() {} | ||
| get B() {} | ||
| set B() {} | ||
| get C() {} | ||
| set C() {} | ||
| D(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: ['field', 'constructor', ['get', 'set'], 'method'], | ||
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| constructor() {} | ||
| B(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: ['field', 'constructor', [], 'method'], | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| constructor() {} | ||
| @Dec() private B: string; | ||
| private C(): void; | ||
| set D() {} | ||
| E(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: [ | ||
| 'public-field', | ||
| 'constructor', | ||
| ['private-decorated-field', 'public-set', 'private-method'], | ||
| 'public-method', | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| constructor() {} | ||
| get B() {} | ||
| get C() {} | ||
| set B() {} | ||
| set C() {} | ||
| D(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: ['field', 'constructor', ['get'], ['set'], 'method'], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| invalid: [ | ||
| { | ||
| @@ -3823,6 +3891,94 @@ class Foo { | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| get B() {} | ||
| constructor() {} | ||
| set B() {} | ||
| get C() {} | ||
| set C() {} | ||
| D(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: ['field', 'constructor', ['get', 'set'], 'method'], | ||
| }, | ||
| ], | ||
| errors: [ | ||
| { | ||
| messageId: 'incorrectGroupOrder', | ||
| data: { | ||
| name: 'constructor', | ||
| rank: 'get, set', | ||
| }, | ||
| line: 5, | ||
| column: 5, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| private C(): void; | ||
| constructor() {} | ||
| @Dec() private B: string; | ||
| set D() {} | ||
| E(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: [ | ||
| 'public-field', | ||
| 'constructor', | ||
| ['private-decorated-field', 'public-set', 'private-method'], | ||
| 'public-method', | ||
| ], | ||
| }, | ||
| ], | ||
| errors: [ | ||
| { | ||
| messageId: 'incorrectGroupOrder', | ||
| data: { | ||
| name: 'constructor', | ||
| rank: 'private decorated field, public set, private method', | ||
| }, | ||
| line: 5, | ||
| column: 5, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| class Foo { | ||
| A: string; | ||
| constructor() {} | ||
| get B() {} | ||
| set B() {} | ||
| get C() {} | ||
| set C() {} | ||
| D(): void; | ||
| } `, | ||
| options: [ | ||
| { | ||
| default: ['field', 'constructor', 'get', ['set'], 'method'], | ||
| }, | ||
| ], | ||
| errors: [ | ||
| { | ||
| messageId: 'incorrectGroupOrder', | ||
| data: { | ||
| name: 'C', | ||
| rank: 'set', | ||
| }, | ||
| line: 7, | ||
| column: 5, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.