This PR introduces member groupping support for themember-ordering rule. For example makes it possible to group fields, getters, and setters at the same rank.

Screen.Recording.2022-02-11.at.02.02.27.mov

Config used in video:

{default: {memberTypes: [// Fields'public-static-field','public-field','protected-static-field','protected-field','private-static-field','private-field',// Constructors'public-constructor','protected-constructor','private-constructor',// Getters & Setters            ['public-get','public-set'],            ['protected-get','protected-set'],            ['private-get','private-set'],// Index signatures'signature',// Methods'public-static-method','public-method','protected-static-method','protected-method','private-static-method','private-method'        ],order:'alphabetically'}

feat(eslint-plugin): added member group support to member-ordering rule

59a1655

Copy link

nx-cloudbot commentedFeb 11, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commitdf0de90. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedFeb 11, 2022

Thanks for the PR,@grabofus!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedFeb 11, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:df0de90

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/6217a81038963400073930d8

bradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule label

Feb 11, 2022

Copy link

codecovbot commentedFeb 11, 2022•
edited
Loading

Codecov Report

Merging#4538 (df0de90) intomain (823b945) willincrease coverage by0.01%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4538      +/-   ##==========================================+ Coverage   94.62%   94.64%   +0.01%==========================================  Files         149      150       +1       Lines        8072     8101      +29       Branches     2581     2589       +8     ==========================================+ Hits         7638     7667      +29  Misses        239      239                Partials      195      195

Flag	Coverage Δ
unittest	`94.64% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/configs/all.ts	`100.00% <ø> (ø)`
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts	`75.00% <ø> (ø)`
...ackages/eslint-plugin/src/rules/member-ordering.ts	`95.68% <100.00%> (+0.12%)`	⬆️
...ges/eslint-plugin/src/rules/space-before-blocks.ts	`100.00% <100.00%> (ø)`

Copy link

splincode commentedFeb 11, 2022

Please, add supportdecorated-get,decorated-set, so that you can write like this:

 // Index signature  "signature",  // Fields  "decorated-field",  "decorated-set",  "field",  // Constructors  "constructor",  // Getters and Setters at the same rank  ["decorated-get", "get", "set"],  // Methods  "method"

we do this in angular projects

Copy link

ContributorAuthor

grabofus commentedFeb 11, 2022•
edited
Loading

@splincode that should already be supported by this PR. I didn't add explicit support forget /set. You can use any of the pre-existing member types in a group.

You config would result in this:

(There is anotherget /set pair above the constructor, just hidden by the popup)

Merge branch 'main' into feat/member-ordering-groups

59f96c5

JoshuaKGoldberg requested changes

Feb 23, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Implementation looks great so far, thanks@grabofus!

Just requesting changes on getting a little more test coverage in.

packages/eslint-plugin/tests/rules/member-ordering.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Feb 23, 2022

grabofus added2 commits

February 24, 2022 14:08

test(eslint-plugin): added more test cases for member-ordering

13a7c9b

test(eslint-plugin): added more test cases for member-ordering

7988384

JoshuaKGoldberg approved these changes

Feb 24, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks@grabofus!

Merge branch 'main' into feat/member-ordering-groups

df0de90

JoshuaKGoldberg merged commit6afcaea intotypescript-eslint:main

Feb 24, 2022

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Mar 8, 2022

Update typescript-eslint monorepo to v5.13.0 (#1192)

ef6ee1f

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.12.1/5.13.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.12.1/5.13.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)##### Bug Fixes-   **eslint-plugin:** \[sort-type-union-intersection-members] Wrap the constructorType in parentheses ([#&#8203;4590](typescript-eslint/typescript-eslint#4590)) ([851bb90](typescript-eslint/typescript-eslint@851bb90))##### Features-   **eslint-plugin:** \[no-misused-promises] check more places for checksVoidReturn ([#&#8203;4541](typescript-eslint/typescript-eslint#4541)) ([052cf51](typescript-eslint/typescript-eslint@052cf51))-   **eslint-plugin:** add `no-redundant-type-constituents` rule ([#&#8203;4378](typescript-eslint/typescript-eslint#4378)) ([63d051e](typescript-eslint/typescript-eslint@63d051e))-   **eslint-plugin:** add `no-useless-empty-export` rule ([#&#8203;4380](typescript-eslint/typescript-eslint#4380)) ([823b945](typescript-eslint/typescript-eslint@823b945))-   **eslint-plugin:** add extension rule `space-before-blocks` ([#&#8203;1606](typescript-eslint/typescript-eslint#1606)) ([#&#8203;4184](typescript-eslint/typescript-eslint#4184)) ([208b6d0](typescript-eslint/typescript-eslint@208b6d0))-   **eslint-plugin:** added member group support to member-ordering rule ([#&#8203;4538](typescript-eslint/typescript-eslint#4538)) ([6afcaea](typescript-eslint/typescript-eslint@6afcaea))#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)##### Bug Fixes-   **eslint-plugin:** \[no-unnecessary-type-arguments] fix comparison of types ([#&#8203;4555](typescript-eslint/typescript-eslint#4555)) ([fc3936e](typescript-eslint/typescript-eslint@fc3936e))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Co-authored-by: 6543 <6543@noreply.codeberg.org>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1192Reviewed-by: 6543 <6543@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actionsbot locked asresolvedand limited conversation to collaborators

May 26, 2022

Labels

awaiting response

Issues waiting for a reply from the OP or another party

enhancement: plugin rule option

New rule option for an existing eslint-plugin rule

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): added member group support to member-ordering rule#4538

feat(eslint-plugin): added member group support to member-ordering rule#4538

Uh oh!

Conversation

grabofus commentedFeb 11, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

nx-cloudbot commentedFeb 11, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedFeb 11, 2022

Uh oh!

netlifybot commentedFeb 11, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedFeb 11, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

splincode commentedFeb 11, 2022

Uh oh!

grabofus commentedFeb 11, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grabofus commentedFeb 11, 2022•
edited
Loading

nx-cloudbot commentedFeb 11, 2022•
edited
Loading

netlifybot commentedFeb 11, 2022•
edited
Loading

codecovbot commentedFeb 11, 2022•
edited
Loading

grabofus commentedFeb 11, 2022•
edited
Loading

JoshuaKGoldberg left a comment•
edited
Loading