As the extraction in this codebase was originally copied fromeslint-plugin-testing-library (see#3677 &testing-library/eslint-plugin-testing-library#329), it seems logical to expose it here so other packages can use it whenever they want.

Copy link

Contributor

typescript-eslintbot commentedFeb 1, 2022

Thanks for the PR,@MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

nx-cloudbot commentedFeb 1, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit59271d1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedFeb 1, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:59271d1

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/6216aeac43b62e000767d953

Copy link

codecovbot commentedFeb 1, 2022•
edited
Loading

Codecov Report

Merging#4503 (59271d1) intomain (0c63f26) willdecrease coverage by2.09%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4503      +/-   ##==========================================- Coverage   94.26%   92.17%   -2.10%==========================================  Files         169      204      +35       Lines        9511     8860     -651       Branches     2973     2752     -221     ==========================================- Hits         8966     8167     -799- Misses        322      484     +162+ Partials      223      209      -14

Flag	Coverage Δ
unittest	`92.17% <100.00%> (-2.10%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/utils/src/ast-utils/index.ts	`100.00% <100.00%> (ø)`
packages/typescript-estree/src/node-utils.ts
packages/typescript-estree/src/convert.ts
...estree/src/create-program/createIsolatedProgram.ts
...pt-estree/src/create-program/createWatchProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...ges/typescript-estree/src/create-program/shared.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
packages/typescript-estree/src/simple-traverse.ts
... and60 more

bradzacher added the enhancementNew feature or request label

Feb 2, 2022

feat(utils): exposeast-utils' helpers

dae2fbb

MichaelDeBoey force-pushed thepatch-51 branch from2945aad todae2fbbCompare

February 12, 2022 03:15

JoshuaKGoldberg approved these changes

Feb 23, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup, this is a good change. Thanks@MichaelDeBoey!

Merge branch 'main' into patch-51

59271d1

JoshuaKGoldbergenabled auto-merge (squash)

February 23, 2022 22:01

Copy link

Member

JoshuaKGoldberg commentedFeb 23, 2022

@bradzacher could I ask for your help merging please? 😄

bradzacherdisabled auto-merge

February 23, 2022 23:35

Copy link

Member

bradzacher commentedFeb 23, 2022•
edited
Loading

yeah automerge won't work unless all the required signals are green.
The codecov signal is red because somehow this caused a 2% drop in coverage...? Wut.

So we just need to admin bypass instead of auto-merging