Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: Add missing comma in CUSTOM_RULES.md#4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intotypescript-eslint:mainfromzaicevas:patch-1
Jan 24, 2022
Merged

docs: Add missing comma in CUSTOM_RULES.md#4464

bradzacher merged 3 commits intotypescript-eslint:mainfromzaicevas:patch-1
Jan 24, 2022

Conversation

@zaicevas
Copy link
Contributor

PR Checklist

Overview

I think the PR title and content is self-explanatory

dimaMachina reacted with thumbs up emoji
@nx-cloud
Copy link

nx-cloudbot commentedJan 20, 2022
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commita4dc161. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@zaicevas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJan 20, 2022
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:a4dc161

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61eddee795c47a00086e86df

😎 Browse the preview:https://deploy-preview-4464--typescript-eslint.netlify.app

@codecov
Copy link

codecovbot commentedJan 20, 2022
edited
Loading

Codecov Report

Merging#4464 (21c9ce1) intomain (8894106) willincrease coverage by1.84%.
The diff coverage isn/a.

❗ Current head21c9ce1 differs from pull request most recent heada4dc161. Consider uploading reports for the commita4dc161 to get more accurate results

@@            Coverage Diff             @@##             main    #4464      +/-   ##==========================================+ Coverage   92.70%   94.54%   +1.84%==========================================  Files         183      147      -36       Lines        9759     7851    -1908       Branches     3054     2516     -538     ==========================================- Hits         9047     7423    -1624+ Misses        480      234     -246+ Partials      232      194      -38
FlagCoverage Δ
unittest94.54% <ø> (+1.84%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/type-utils/src/typeFlagUtils.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/type-utils/src/getTokenAtPosition.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/convert.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/type-utils/src/isUnsafeAssignment.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
... and26 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJan 23, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😄 nice find, thanks!

@bradzacherbradzacher added the documentationDocumentation ("docs") that needs adding/updating labelJan 24, 2022
@bradzacherbradzacher merged commitd8256b7 intotypescript-eslint:mainJan 24, 2022
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull requestFeb 12, 2022
* Add missing comma in docs* chore: ran PrettierCo-authored-by: Josh Goldberg <me@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

documentationDocumentation ("docs") that needs adding/updating

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaicevas@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp