Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: simplify git hooks#445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 1 commit intomasterfromcleanup-hooks
Apr 20, 2019
Merged

chore: simplify git hooks#445

JamesHenry merged 1 commit intomasterfromcleanup-hooks
Apr 20, 2019

Conversation

@bradzacher
Copy link
Member

Closes#259

We have too many tests to run at commit time now.
I would also say that there are too many to run at push time, as well.
Our CI will run all of the tests (incl integration tests), so there's no need to force contributors to wait through a full test cycle every commit/push.

  • change pre-commit hook to only run prettier.
    • commit hooks are used regularly, so we want it to be as lightweight as possible.
  • add pre-push hook which runs lint + typecheck + format.
    • these are all much heavier (total i find takes ~30-40s), but I think it's good to try and block pushes because of these - some of the most common errors I see are lint problems or unformatted files.

My question (for@JamesHenry, who I think added it?), is do we need commitizen? It's just admins that can push to master, otherwise all branch commits are hidden behind a squashed PR message (which is enforced via one of the PR status checks) - so enforcing a commit message style on the client seems unnecessary?

mysticatea, j-f1, and JoshuaKGoldberg reacted with thumbs up emoji
@JamesHenryJamesHenry merged commit9559323 intomasterApr 20, 2019
@JamesHenryJamesHenry deleted the cleanup-hooks branchApril 20, 2019 20:23
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Out of memory error in pre-commit hook

3 participants

@bradzacher@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp