typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(type-utils): isTypeReadonly now handles conditional types#4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 16 commits intotypescript-eslint:mainfromRebeccaStevens:issue-4420

Jan 17, 2022

Merged

fix(type-utils): isTypeReadonly now handles conditional types#4421

bradzacher merged 16 commits intotypescript-eslint:mainfromRebeccaStevens:issue-4420

Jan 17, 2022

Conversation

Copy link

Contributor

RebeccaStevens commentedJan 9, 2022•
edited
Loading

PR Checklist

Addresses an existing issue:fixes[isTypeReadonly] Conditional types are always marked as readonly #4420
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

isTypeReadonly now checks conditional types properly.

Note: This PR builds off#4416

fix(type-utils): make isTypeReadonly's options param optional

974858a

fixtypescript-eslint#4410

Copy link

nx-cloudbot commentedJan 9, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit2b275e8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJan 9, 2022

Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedJan 9, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:2b275e8

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61e54bda2b6bcd00070cb973

Copy link

codecovbot commentedJan 9, 2022•
edited
Loading

Codecov Report

Merging#4421 (2b275e8) intomain (ef3147c) willdecrease coverage by1.54%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4421      +/-   ##==========================================- Coverage   94.23%   92.68%   -1.55%==========================================  Files         169      161       -8       Lines        9448     8151    -1297       Branches     2948     2616     -332     ==========================================- Hits         8903     7555    -1348- Misses        321      396      +75+ Partials      224      200      -24

Flag	Coverage Δ
unittest	`92.68% <100.00%> (-1.55%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/isTypeReadonly.ts	`79.77% <100.00%> (ø)`
packages/eslint-plugin/src/rules/no-extra-semi.ts	`54.54% <0.00%> (-12.13%)`	⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts
packages/typescript-estree/src/version-check.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/convert-comments.ts
...-internal/src/rules/no-typescript-estree-import.ts
...ript-estree/src/create-program/createSourceFile.ts
...-estree/src/create-program/createProjectProgram.ts
... and28 more