Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(type-utils): check IndexSignature internals when checking isTypeReadonly#4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 9 commits intotypescript-eslint:mainfromRebeccaStevens:issue-3714
Jan 17, 2022

Conversation

RebeccaStevens
Copy link
Contributor

PR Checklist

Overview

isTypeReadonly now checks the details of anIndexSignature; not just the outer readonlyness.

Note: This PR builds off#4416

@nx-cloud
Copy link

nx-cloudbot commentedJan 9, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit186756a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJan 9, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:186756a

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61e523a508b7610007a53db2

@RebeccaStevensRebeccaStevens marked this pull request as ready for reviewJanuary 10, 2022 12:55
@RebeccaStevensRebeccaStevens marked this pull request as draftJanuary 10, 2022 12:57
@RebeccaStevensRebeccaStevens marked this pull request as ready for reviewJanuary 10, 2022 13:52
@bradzacherbradzacher added the bugSomething isn't working labelJan 11, 2022
@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 17, 2022
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelJan 17, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for fixing this!

@bradzacherbradzacher merged commitef3147c intotypescript-eslint:mainJan 17, 2022
@RebeccaStevensRebeccaStevens deleted the issue-3714 branchJanuary 17, 2022 09:11
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull requestFeb 12, 2022
…eadonly (typescript-eslint#4417)* fix(type-utils): make isTypeReadonly's options param optionalfixtypescript-eslint#4410* test(type-utils): add basic tests for isTypeReadonly* test(type-utils): add test for IndexSignature internals* fix(type-utils): check IndexSignature internals when checking isTypeReadonlyfixtypescript-eslint#3714* perf(type-utils): don't test IndexSignature key for readonlyness as it will always be readonlyCo-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] IndexSignature internals don't violate the rule
2 participants
@RebeccaStevens@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp