Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(type-utils): add basic tests for isTypeReadonly#4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

RebeccaStevens
Copy link
Contributor

@RebeccaStevensRebeccaStevens commentedJan 9, 2022
edited
Loading

PR Checklist

Overview

Add basic tests forisTypeReadonly.

Note: this PR is the base of#4417,#4419,#4421 and#4429

JoshuaKGoldberg reacted with heart emoji
@nx-cloud
Copy link

nx-cloudbot commentedJan 9, 2022
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commitc7051e1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJan 9, 2022
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:c7051e1

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61dd6ee114e55d0007cccfcf

@codecov
Copy link

codecovbot commentedJan 9, 2022
edited
Loading

Codecov Report

Merging#4416 (c7051e1) intomain (e61e388) willincrease coverage by0.34%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4416      +/-   ##==========================================+ Coverage   94.26%   94.61%   +0.34%==========================================  Files         169      147      -22       Lines        9440     7841    -1599       Branches     2940     2507     -433     ==========================================- Hits         8899     7419    -1480+ Misses        321      233      -88+ Partials      220      189      -31
FlagCoverage Δ
unittest94.61% <ø> (+0.34%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...escript-estree/src/semantic-or-syntactic-errors.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/node-utils.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/typescript-estree/src/ast-converter.ts
packages/typescript-estree/src/convert-comments.ts
packages/typescript-estree/src/ts-estree/index.ts
packages/typescript-estree/src/version-check.ts
... and12 more

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks so much for adding this!

RebeccaStevens reacted with thumbs up emoji
@bradzacherbradzacher merged commitea85dda intotypescript-eslint:mainJan 17, 2022
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull requestFeb 12, 2022
…nt#4416)* fix(type-utils): make isTypeReadonly's options param optionalfixtypescript-eslint#4410* test(type-utils): add basic tests for isTypeReadonly
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 17, 2022
@RebeccaStevensRebeccaStevens deleted the isTypeReadonly-tests branchMarch 10, 2023 23:27
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
testsanything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@RebeccaStevens@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp