Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(type-utils): make isTypeReadonly's options param optional#4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

RebeccaStevens
Copy link
Contributor

PR Checklist

Overview

Use the default options as the default param.

@nx-cloud
Copy link

nx-cloudbot commentedJan 9, 2022•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit974858a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJan 9, 2022•
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:974858a

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61da7c5a8e31750007f7cb0d

😎 Browse the preview:https://deploy-preview-4415--typescript-eslint.netlify.app

@codecov
Copy link

codecovbot commentedJan 9, 2022•
edited
Loading

Codecov Report

Merging#4415 (974858a) intomain (97c0e86) willincrease coverage by0.02%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main    #4415      +/-   ##==========================================+ Coverage   91.95%   91.97%   +0.02%==========================================  Files         346      161     -185       Lines       11622     8125    -3497       Branches     3298     2599     -699     ==========================================- Hits        10687     7473    -3214+ Misses        675      460     -215+ Partials      260      192      -68
FlagCoverage Δ
unittest91.97% <0.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/type-utils/src/isTypeReadonly.ts0.00% <0.00%> (ø)
packages/scope-manager/src/scope/FunctionScope.ts
...ope-manager/src/definition/TSEnumNameDefinition.ts
packages/experimental-utils/src/ast-utils/index.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
packages/scope-manager/src/ScopeManager.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/lib.ts
...perimental-utils/src/ts-eslint-scope/Referencer.ts
packages/scope-manager/src/lib/es2018.regexp.ts
... and176 more

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works for me, thanks!

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)January 9, 2022 23:25
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commentedJan 9, 2022•
edited
Loading

I'm surprised a 0% diff is marked as a blocker for codecov... I'll investigate a bit more if#4418 isn't merged soon.

@bradzacherbradzacher added the enhancementNew feature or request labelJan 11, 2022
@bradzacherbradzacher changed the titlefix(type-utils): make isTypeReadonly's options param optionalfeat(type-utils): make isTypeReadonly's options param optionalJan 11, 2022
@bradzacherbradzacher changed the titlefeat(type-utils): make isTypeReadonly's options param optionalfix(type-utils): make isTypeReadonly's options param optionalJan 11, 2022
@bradzacherbradzacher changed the titlefix(type-utils): make isTypeReadonly's options param optionalfeat(type-utils): make isTypeReadonly's options param optionalJan 11, 2022
@bradzacherbradzacher merged commit3a07a56 intotypescript-eslint:mainJan 11, 2022
@RebeccaStevensRebeccaStevens deleted the issue-4410 branchJanuary 11, 2022 07:56
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[isTypeReadonly] options parameter should be optional
3 participants
@RebeccaStevens@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp