Adds"@typescript-eslint/types" underimplicitDependencies for theeslint-plugin package so thatnpx nx build website knows to build types and therefore copyast-spec.ts.

Also adds aconsole.error in case thecopy-ast-spec code throws for whatever reason.

fix: added missing implicit dependency on types to eslint-plugin

0162eb6

Copy link

nx-cloudbot commentedDec 31, 2021•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit467cffd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedDec 31, 2021

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedDec 31, 2021•
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:467cffd

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61d204563811e50008f4d435

😎 Browse the preview:https://deploy-preview-4381--typescript-eslint.netlify.app

Copy link

codecovbot commentedDec 31, 2021•
edited
Loading

Codecov Report

Merging#4381 (467cffd) intomain (ccee1a2) willdecrease coverage by0.43%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4381      +/-   ##==========================================- Coverage   94.61%   94.18%   -0.44%==========================================  Files         147      294     +147       Lines        7841    10959    +3118       Branches     2507     3169     +662     ==========================================+ Hits         7419    10322    +2903- Misses        233      383     +150- Partials      189      254      +65

Flag	Coverage Δ
unittest	`94.18% <ø> (-0.44%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/lib/es2018.promise.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/esnext.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2019.array.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2021.full.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/webworker.ts	`100.00% <0.00%> (ø)`
...ges/scope-manager/src/definition/DefinitionBase.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2015.core.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/variable/index.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2019.ts	`100.00% <0.00%> (ø)`
...-internal/src/rules/no-typescript-estree-import.ts	`87.50% <0.00%> (ø)`
... and137 more

Copy link

Member

bradzacher commentedJan 1, 2022

I believe that this should be listed within thetypscript-estree package instead of in theeslint-plugin package because that's where the copy script outputs to

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-estree/project.json

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Jan 1, 2022

bradzacher changed the title~~fix: added missing implicit dependency on types to eslint-plugin~~chore: added missing implicit dependency on types to eslint-plugin

Jan 1, 2022

JoshuaKGoldbergand others added2 commits

January 2, 2022 14:59

chore: move to typescript-estree

f7708f8

Merge branch 'main' into missing-implicit-types-dependency

467cffd