Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): addno-redundant-type-constituents rule#4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloudbot commentedDec 31, 2021•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commitecd559a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedDec 31, 2021•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:ecd559a

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/62169a537a5edf00084ea3c0

@JoshuaKGoldbergJoshuaKGoldbergforce-pushed theno-redundant-type-constituents branch 2 times, most recently from0fb2b24 tob8bc780CompareDecember 31, 2021 07:31
@JoshuaKGoldbergJoshuaKGoldbergforce-pushed theno-redundant-type-constituents branch fromb8bc780 to17b7fb0CompareDecember 31, 2021 07:32
@JoshuaKGoldbergJoshuaKGoldberg added DO NOT MERGEPRs which should not be merged yet enhancement: new plugin ruleNew rule request for eslint-plugin labelsDec 31, 2021
@codecov
Copy link

codecovbot commentedJan 2, 2022•
edited
Loading

Codecov Report

Merging#4378 (ecd559a) intomain (0c63f26) willincrease coverage by0.34%.
The diff coverage is94.28%.

@@            Coverage Diff             @@##             main    #4378      +/-   ##==========================================+ Coverage   94.26%   94.61%   +0.34%==========================================  Files         169      148      -21       Lines        9511     8052    -1459       Branches     2973     2575     -398     ==========================================- Hits         8966     7618    -1348+ Misses        322      239      -83+ Partials      223      195      -28
FlagCoverage Δ
unittest94.61% <94.28%> (+0.34%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/configs/all.ts100.00% <ø> (ø)
...plugin/src/rules/no-redundant-type-constituents.ts93.89% <93.89%> (ø)
packages/eslint-plugin/src/util/misc.ts94.44% <100.00%> (+1.11%)⬆️
...t-estree/src/create-program/useProvidedPrograms.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/ast-converter.ts
packages/typescript-estree/src/version-check.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
... and15 more

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJanuary 2, 2022 20:02
@bradzacherbradzacher removed the DO NOT MERGEPRs which should not be merged yet labelJan 2, 2022
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftJanuary 13, 2022 05:13
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJanuary 23, 2022 23:01
bradzacher
bradzacher previously approved these changesFeb 2, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking good to me!
A few comments, but nothing blocking.
Feel free to merge when you're happy with it!

JoshuaKGoldberg reacted with rocket emoji
overridden: `'{{typeName}}' is overridden by other types in this {{container}} type.`,
overrides: `'{{typeName}}' overrides all other types in this {{container}} type.`,
},
schema: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One thing that might be nice is adding an option which allows you to ignore certain types.
I don't think we need it now, but it might be a good future addition to the rule for codebases that do "unnecessary unions" for documentation reasons.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mmhh yeah that would be nice. Another example of a place where we'd want to set up a unified way to describe types...

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelFeb 2, 2022
@bradzacherbradzacher merged commit63d051e intotypescript-eslint:mainFeb 23, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the no-redundant-type-constituents branchFebruary 23, 2022 23:59
JoshuaKGoldberg added a commit to JoshuaKGoldberg/typescript-eslint that referenced this pull requestFeb 27, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestMar 8, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.12.1/5.13.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.12.1/5.13.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)##### Bug Fixes-   **eslint-plugin:** \[sort-type-union-intersection-members] Wrap the constructorType in parentheses ([#&#8203;4590](typescript-eslint/typescript-eslint#4590)) ([851bb90](typescript-eslint/typescript-eslint@851bb90))##### Features-   **eslint-plugin:** \[no-misused-promises] check more places for checksVoidReturn ([#&#8203;4541](typescript-eslint/typescript-eslint#4541)) ([052cf51](typescript-eslint/typescript-eslint@052cf51))-   **eslint-plugin:** add `no-redundant-type-constituents` rule ([#&#8203;4378](typescript-eslint/typescript-eslint#4378)) ([63d051e](typescript-eslint/typescript-eslint@63d051e))-   **eslint-plugin:** add `no-useless-empty-export` rule ([#&#8203;4380](typescript-eslint/typescript-eslint#4380)) ([823b945](typescript-eslint/typescript-eslint@823b945))-   **eslint-plugin:** add extension rule `space-before-blocks` ([#&#8203;1606](typescript-eslint/typescript-eslint#1606)) ([#&#8203;4184](typescript-eslint/typescript-eslint#4184)) ([208b6d0](typescript-eslint/typescript-eslint@208b6d0))-   **eslint-plugin:** added member group support to member-ordering rule ([#&#8203;4538](typescript-eslint/typescript-eslint#4538)) ([6afcaea](typescript-eslint/typescript-eslint@6afcaea))#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)##### Bug Fixes-   **eslint-plugin:** \[no-unnecessary-type-arguments] fix comparison of types ([#&#8203;4555](typescript-eslint/typescript-eslint#4555)) ([fc3936e](typescript-eslint/typescript-eslint@fc3936e))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Co-authored-by: 6543 <6543@noreply.codeberg.org>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1192Reviewed-by: 6543 <6543@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@fregante
Copy link
Contributor

fregante commentedMay 22, 2022•
edited
Loading

💚

I just started using this (via XO) and it already found a few bugs around. For whatever reason, some types weren't resolving soany was being propagated throughout the code. TypeScript is gladly letting this happen, but this rule caught it.

Seen on this commit and further comment:refined-github/refined-github@f298b56 (#5654)

bradzacher reacted with heart emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancement: new plugin ruleNew rule request for eslint-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule proposal: Disallow unions withunknown orany

3 participants

@JoshuaKGoldberg@fregante@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp