Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

tests: add cypress-axe test for homepage#4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 29, 2021•
edited
Loading

PR Checklist

Overview

Uses the failures table loggingsuggested in cypress-axe's docs:

┌─────────┬──────────────────────────────────────────────────────┬───────────────────────┬────────────┬───────┐│ (index) │                       description                    │          id           │   impact   │ nodes │├─────────┼──────────────────────────────────────────────────────┼───────────────────────┼────────────┼───────┤│    0    │  'Ensure image alternative is not repeated as text'  │ 'image-redundant-alt' │  'minor'   │   1   ││    1    │ 'Ensures all page content is contained by landmarks' │       'region'        │ 'moderate' │   1   │└─────────┴───────────────────────────────────────────────────────────────────────────────────────────────────┴

Screenshot and video artifacts are made available perhttps://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts.

Index -- is accessible (failed)

@nx-cloud
Copy link

nx-cloudbot commentedDec 29, 2021•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commitb91a294. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedDec 29, 2021•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:b91a294

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/6220a16efdccad0007afdbfd

@bradzacherbradzacher added documentationDocumentation ("docs") that needs adding/updating testsanything to do with testing labelsDec 29, 2021
@JoshuaKGoldbergJoshuaKGoldberg added the DO NOT MERGEPRs which should not be merged yet labelDec 30, 2021
@codecov
Copy link

codecovbot commentedFeb 12, 2022•
edited
Loading

Codecov Report

Merging#4362 (b91a294) intomain (fabfc2b) willincrease coverage by0.19%.
The diff coverage is98.64%.

@@            Coverage Diff             @@##             main    #4362      +/-   ##==========================================+ Coverage   92.41%   92.61%   +0.19%==========================================  Files         350      303      -47       Lines       12059    10988    -1071       Branches     3430     3257     -173     ==========================================- Hits        11144    10176     -968+ Misses        642      554      -88+ Partials      273      258      -15
FlagCoverage Δ
unittest92.61% <98.64%> (+0.19%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts97.14% <92.85%> (-0.16%)⬇️
...gin/src/rules/naming-convention-utils/validator.ts94.96% <100.00%> (-0.55%)⬇️
...ges/eslint-plugin/src/rules/no-misused-promises.ts98.71% <100.00%> (+0.07%)⬆️
...es/eslint-plugin/src/rules/prefer-function-type.ts97.14% <100.00%> (-0.05%)⬇️
packages/scope-manager/src/variable/index.ts50.00% <0.00%> (-50.00%)⬇️
packages/typescript-estree/src/ts-estree/index.ts66.66% <0.00%> (-33.34%)⬇️
...es/eslint-plugin/src/util/getOperatorPrecedence.ts31.42% <0.00%> (-28.58%)⬇️
packages/type-utils/src/predicates.ts36.23% <0.00%> (-2.66%)⬇️
packages/scope-manager/src/referencer/Reference.ts88.00% <0.00%> (-2.00%)⬇️
.../src/rules/sort-type-union-intersection-members.ts90.74% <0.00%> (-1.80%)⬇️
... and192 more

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 23, 2022 23:06
@bradzacherbradzacher removed the DO NOT MERGEPRs which should not be merged yet labelFeb 23, 2022
bradzacher
bradzacher previously approved these changesFeb 23, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg reacted with heart emoji
@bradzacher
Copy link
Member

image

awkward

@JoshuaKGoldberg
Copy link
MemberAuthor

Better we get the e2e test flake out now than in random unrelated PRs...

bradzacher reacted with laugh emoji

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftMarch 1, 2022 22:44
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedMar 3, 2022•
edited
Loading

<button type=\"button\" class=\"DocSearch DocSearch-Button\" aria-label=\"Search\">

Element has insufficient color contrast of 4.48 (foreground color: #7d8293, background color: #1a1b22, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1

https://www.color-hex.com/color/7d8293 -> that'srgb(125, 130, 147). But the actual color of the Search button isrgb(127, 132, 151).

My hunch from previous Cypress aXe color contrast flake is that the page is still transitioning colors in some way. Other thandisabling animations altogether in tests (a little heavyweight IMO) I have yet to implement any better solution than upping thecy.wait 😢 .

I do want to play withhttps://developer.mozilla.org/en-US/docs/Web/API/Document/getAnimations though... maybe that's a good library to make.

@bradzacherbradzacher changed the titlechore: add cypress-axe test for homepagetests: add cypress-axe test for homepageMar 3, 2022
@bradzacherbradzacher merged commit4ed686f intotypescript-eslint:mainMar 3, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the cypress-axe branchMarch 3, 2022 19:21
@armano2
Copy link
Collaborator

i noticed somethign bad happening after this change,

html:root has higher priority thanhtml[data-theme='dark'] and it looks that dark mode overrides are no longer working correctly

image

and this should be

image

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updatingtestsanything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add accessibility/aXe audits on the website as part of CI
3 participants
@JoshuaKGoldberg@bradzacher@armano2
[8]ページ先頭
©2009-2025 Movatter.jp