Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [consistent-indexed-object-style] do not report for circular references#4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 2 commits intomainfromfix/2687-consistent-indexed-object-style
Dec 27, 2021

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedDec 26, 2021•
edited
Loading

EvgenyOrekhov reacted with thumbs up emoji
@armano2armano2 added bugSomething isn't working package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin labelsDec 26, 2021
@armano2armano2 self-assigned thisDec 26, 2021
@nx-cloud
Copy link

nx-cloudbot commentedDec 26, 2021•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commita9c2b3d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedDec 26, 2021•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:a9c2b3d

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61c827fd6af1e000079a6817

@codecov
Copy link

codecovbot commentedDec 26, 2021•
edited
Loading

Codecov Report

Merging#4347 (a9c2b3d) intomain (9f58eab) willincrease coverage by1.47%.
The diff coverage is95.72%.

@@            Coverage Diff             @@##             main    #4347      +/-   ##==========================================+ Coverage   92.73%   94.21%   +1.47%==========================================  Files         335      152     -183       Lines       11542     8118    -3424       Branches     3289     2599     -690     ==========================================- Hits        10704     7648    -3056+ Misses        364      266      -98+ Partials      474      204     -270
FlagCoverage Δ
unittest94.21% <95.72%> (+1.47%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/array-type.ts97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts76.33% <ø> (ø)
packages/eslint-plugin/src/rules/semi.ts92.85% <ø> (ø)
...lugin/src/rules/padding-line-between-statements.ts93.83% <75.00%> (+2.92%)⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts94.26% <93.33%> (+0.78%)⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts97.70% <94.44%> (+1.86%)⬆️
...lugin/src/rules/consistent-indexed-object-style.ts92.06% <100.00%> (+2.26%)⬆️
...nt-plugin/src/rules/consistent-type-definitions.ts97.29% <100.00%> (+8.10%)⬆️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts97.05% <100.00%> (+2.94%)⬆️
... and245 more

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks for this

@bradzacherbradzacher merged commit6edebcd intomainDec 27, 2021
@bradzacherbradzacher deleted the fix/2687-consistent-indexed-object-style branchDecember 27, 2021 06:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

@armano2armano2

Labels
bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/consistent-indexed-object-style] Fails on circular references
2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp