fix(eslint-plugin): [consistent-type-definitions] correct fixer with declare keyword#4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfromfix/consistent-type-definitions-declare-fixer

Dec 21, 2021

Merged

fix(eslint-plugin): [consistent-type-definitions] correct fixer with declare keyword#4334

bradzacher merged 1 commit intomainfromfix/consistent-type-definitions-declare-fixer

Dec 21, 2021

Conversation

Copy link

Collaborator

armano2 commentedDec 20, 2021

PR Checklist

Addresses an existing issue:fixes[consistent-type-definitions] invalid fixer for declare type #4333
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Fixer incorrectly changes declare keyword to interface

fix(eslint-plugin): [consistent-type-definitions] correct fixer with …

8b4288a

…declare keyword

armano2 added bug

Something isn't working

package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin labels

Dec 20, 2021

armano2 self-assigned this

Dec 20, 2021

Copy link

nx-cloudbot commentedDec 20, 2021•
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit8b4288a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 fromNxCloud.

This comment has been minimized.

Copy link

netlifybot commentedDec 20, 2021•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:8b4288a

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61c0fa45d8c444000897bf3a

Copy link

codecovbot commentedDec 20, 2021•
edited
Loading

Codecov Report

Merging#4334 (8b4288a) intomain (c3e1834) willincrease coverage by0.67%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4334      +/-   ##==========================================+ Coverage   93.52%   94.20%   +0.67%==========================================  Files         336      152     -184       Lines       11596     8104    -3492       Branches     3291     2592     -699     ==========================================- Hits        10845     7634    -3211+ Misses        479      266     -213+ Partials      272      204      -68

Flag	Coverage Δ
unittest	`94.20% <100.00%> (+0.67%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts	`97.29% <100.00%> (ø)`
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/scope/SwitchScope.ts
...l-utils/src/ast-utils/eslint-utils/astUtilities.ts
...rimental-utils/src/ast-utils/eslint-utils/index.ts
packages/scope-manager/src/lib/es2020.intl.ts
...ges/experimental-utils/src/ast-utils/predicates.ts
...scope-manager/src/definition/VariableDefinition.ts
...s/scope-manager/src/scope/ClassStaticBlockScope.ts
packages/typescript-estree/src/ast-converter.ts
... and175 more