Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [restrict-plus-operand] add allowAny option#4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lonyele
Copy link
Contributor

PR Checklist

Overview

It allowsany to be used with the current implementation that stringType such asany,string,bigint,number are possible to be added, but not withinvalid types.

  1. I didn't introduce new warning messages because I couldn't think of good namings. I found thatnotNumbers catches all warnings thus used it here too.
  2. While tidying upif/else statement, code becameif with return style, but if the code withif/else looks better, I'll
    change it.
  3. I reformatted docs to more recent style
  4. I couldn't push the code tofeat(eslint-plugin): [restrict-plus-operands] add allowAny option #901, so I made a new one(again, sorry about the previous pr)

papb reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedDec 6, 2021•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

🔨 Explore the source changes:578fa4b

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61ade7a8c861b20007f3b6bd

@nx-cloud
Copy link

nx-cloudbot commentedDec 6, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commit578fa4b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000Node 12.x - nx run-many --target=typecheck --all --parallel
#000000Node 12.x - nx test @typescript-eslint/parser
#000000Node 12.x - nx test @typescript-eslint/experimental-utils
#000000Node 12.x - nx test @typescript-eslint/scope-manager
#000000Node 12.x - nx test @typescript-eslint/visitor-keys
#000000Node 12.x - nx test @typescript-eslint/typescript-estree

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedDec 6, 2021•
edited
Loading

Codecov Report

Merging#4260 (578fa4b) intomain (9f58eab) willincrease coverage by0.62%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4260      +/-   ##==========================================+ Coverage   92.73%   93.36%   +0.62%==========================================  Files         335      152     -183       Lines       11542     8064    -3478       Branches     3289     2593     -696     ==========================================- Hits        10704     7529    -3175+ Misses        364      179     -185+ Partials      474      356     -118
FlagCoverage Δ
unittest93.36% <100.00%> (+0.62%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts100.00% <100.00%> (ø)
packages/scope-manager/src/lib/dom.iterable.ts
packages/scope-manager/src/lib/dom.ts
packages/scope-manager/src/lib/es2021.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/index.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
packages/scope-manager/src/lib/webworker.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/es2015.reflect.ts
... and174 more

@bradzacherbradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labelDec 9, 2021
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks! ✨

lonyele and papb reacted with hooray emoji
@bradzacherbradzacher merged commit2788545 intotypescript-eslint:mainDec 20, 2021
@lonyelelonyele deleted the feature/add-allow-any-option branchDecember 20, 2021 12:42
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[restrict-plus-operands] Allowing any for summands
3 participants
@lonyele@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp