fix(scope-manager): support static class blocks#4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromjuank1809:class-static-scope

Nov 23, 2021

Merged

fix(scope-manager): support static class blocks#4211

bradzacher merged 1 commit intotypescript-eslint:mainfromjuank1809:class-static-scope

Nov 23, 2021

Conversation

Copy link

Contributor

juank1809 commentedNov 23, 2021

PR Checklist

Addresses an existing issue:fixes[scope analysis] true support for static class blocks #4120
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Created a new Scope Type and added it to the ScopeManager

fix: support class static scope

ea6f832

Copy link

Contributor

typescript-eslintbot commentedNov 23, 2021

Thanks for the PR,@juank1809!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedNov 23, 2021•
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:ea6f832

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/619d54734567ee00089b5606

😎 Browse the preview:https://deploy-preview-4211--typescript-eslint.netlify.app

Copy link

nx-cloudbot commentedNov 23, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commitea6f832. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	`Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 16.x - nx test @typescript-eslint/eslint-plugin`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-internal`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin`
	`Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 14.x - nx test @typescript-eslint/eslint-plugin`
	`Node 16.x - nx test @typescript-eslint/parser`
	`Node 16.x - nx test @typescript-eslint/experimental-utils`
	`Node 16.x - nx test @typescript-eslint/scope-manager`
	`Node 12.x - nx test @typescript-eslint/parser`
	`Node 12.x - nx run-many --target=typecheck --all --parallel`
	`Node 12.x - nx test @typescript-eslint/parser`
	`Node 12.x - nx test @typescript-eslint/experimental-utils`
	`Node 14.x - nx test @typescript-eslint/parser`
	`Node 12.x - nx test @typescript-eslint/scope-manager`
	`Node 12.x - nx test @typescript-eslint/visitor-keys`
	`Node 12.x - nx test @typescript-eslint/typescript-estree`