typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix: correct issues with circular imports#4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomasterfromfix/circular-imports

Nov 15, 2021

Merged

fix: correct issues with circular imports#4140

bradzacher merged 1 commit intomasterfromfix/circular-imports

Nov 15, 2021

Conversation

Copy link

Collaborator

armano2 commentedNov 15, 2021•
edited
Loading

PR Checklist

Addresses an existing issue: fixes
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Ensure that we are not doing circular imports in code-base, this change has been extracted from#4108

fix: correct issues with circular imports

512e520

Copy link

Contributor

typescript-eslintbot commentedNov 15, 2021

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedNov 15, 2021•
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:512e520

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/6191c71df56a900008f27023

😎 Browse the preview:https://deploy-preview-4140--typescript-eslint.netlify.app

armano2 added package: eslint-plugin

Issues related to @typescript-eslint/eslint-plugin

package: scope-manager

Issues related to @typescript-eslint/scope-manager

performanceIssues regarding performance labels

Nov 15, 2021

Copy link

nx-cloudbot commentedNov 15, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commit512e520. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	`Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 16.x - nx test @typescript-eslint/eslint-plugin`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-internal`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin`
	`Node 12.x - nx test @typescript-eslint/eslint-plugin`
	`Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint`
	`Node 14.x - nx test @typescript-eslint/eslint-plugin`
	`Node 12.x - nx run-many --target=typecheck --all --parallel`
	`Node 16.x - nx test @typescript-eslint/parser`
	`Node 16.x - nx test @typescript-eslint/experimental-utils`
	`Node 16.x - nx test @typescript-eslint/scope-manager`
	`Node 12.x - nx test @typescript-eslint/parser`
	`Node 14.x - nx test @typescript-eslint/parser`
	`Node 12.x - nx test @typescript-eslint/parser`
	`Node 12.x - nx test @typescript-eslint/experimental-utils`
	`Node 14.x - nx test @typescript-eslint/experimental-utils`
	`Node 12.x - nx test @typescript-eslint/experimental-utils`
	`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedNov 15, 2021•
edited
Loading

Codecov Report

Merging#4140 (512e520) intomaster (87cfc6a) willdecrease coverage by0.43%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #4140      +/-   ##==========================================- Coverage   93.14%   92.70%   -0.44%==========================================  Files         157      315     +158       Lines        8251    10124    +1873       Branches     2640     2906     +266     ==========================================+ Hits         7685     9385    +1700- Misses        192      306     +114- Partials      374      433      +59

Flag	Coverage Δ
unittest	`92.70% <100.00%> (-0.44%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts	`96.49% <ø> (ø)`
...s/eslint-plugin/src/util/collectUnusedVariables.ts	`91.94% <100.00%> (ø)`
packages/eslint-plugin/src/util/isTypeReadonly.ts	`94.44% <100.00%> (+0.07%)`	⬆️
...ges/scope-manager/src/referencer/PatternVisitor.ts	`68.29% <100.00%> (ø)`
packages/eslint-plugin-tslint/src/custom-linter.ts	`100.00% <0.00%> (ø)`
...s/scope-manager/src/lib/es2020.symbol.wellknown.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2016.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/esnext.string.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/variable/Variable.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2020.intl.ts	`100.00% <0.00%> (ø)`
... and152 more