Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat: add RuleCreator.withoutDocs#4136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add RuleCreator.withoutDocs#4136
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
netlifybot commentedNov 13, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✔️ Deploy Preview fortypescript-eslint ready! 🔨 Explore the source changes:ba132ea 🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61912c8fc1d6b400089c0f91 😎 Browse the preview:https://deploy-preview-4136--typescript-eslint.netlify.app |
nx-cloudbot commentedNov 13, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedNov 13, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #4136 +/- ##==========================================- Coverage 93.35% 93.14% -0.22%========================================== Files 152 157 +5 Lines 8035 8251 +216 Branches 2579 2640 +61 ==========================================+ Hits 7501 7685 +184- Misses 180 192 +12- Partials 354 374 +20
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PR Checklist
Overview
Allows this:
I'm not 100% attached to this particular API. I chose it because it forces people to import
RuleCreator
anyway and has a"you're not documenting this" name.Adds a bit of JSDoc around the two functions to help make them clear in IDEs.