Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add RuleCreator.withoutDocs#4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Allows this:

import{ESLintUtils}from'@typescript-eslint/experimental-utils';constmyRule=ESLintUtils.RuleCreator.withoutDocs({create(context){// ...},meta:{// ...},});

I'm not 100% attached to this particular API. I chose it because it forces people to importRuleCreator anyway and has a"you're not documenting this" name.

Adds a bit of JSDoc around the two functions to help make them clear in IDEs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedNov 13, 2021
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:ba132ea

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61912c8fc1d6b400089c0f91

😎 Browse the preview:https://deploy-preview-4136--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloudbot commentedNov 13, 2021
edited
Loading

Nx Cloud Report

CI ran the following commands for commitba132ea. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000Node 12.x - nx run-many --target=typecheck --all --parallel
#000000Node 14.x - nx test @typescript-eslint/parser
#000000Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000Node 14.x - nx test @typescript-eslint/experimental-utils
#000000Node 16.x - nx test @typescript-eslint/parser
#000000Node 14.x - nx test @typescript-eslint/scope-manager
#000000Node 14.x - nx test @typescript-eslint/visitor-keys
#000000Node 14.x - nx test @typescript-eslint/typescript-estree
#000000Node 12.x - nx test @typescript-eslint/parser
#000000Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000Node 12.x - nx test @typescript-eslint/parser

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftNovember 13, 2021 19:25
@codecov
Copy link

codecovbot commentedNov 13, 2021
edited
Loading

Codecov Report

Merging#4136 (ba132ea) intomaster (ae0fb5a) willdecrease coverage by0.21%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #4136      +/-   ##==========================================- Coverage   93.35%   93.14%   -0.22%==========================================  Files         152      157       +5       Lines        8035     8251     +216       Branches     2579     2640      +61     ==========================================+ Hits         7501     7685     +184- Misses        180      192      +12- Partials      354      374      +20
FlagCoverage Δ
unittest93.14% <100.00%> (-0.22%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin/src/rules/no-confusing-non-null-assertion.ts82.60% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts93.50% <ø> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts90.00% <ø> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts97.83% <ø> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts98.48% <100.00%> (+0.02%)⬆️
...gin-internal/src/rules/no-poorly-typed-ts-props.ts88.88% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts81.34% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts91.30% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts87.50% <0.00%> (ø)
... and1 more

@bradzacherbradzacher added the enhancementNew feature or request labelNov 14, 2021
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bradzacherbradzacher merged commit87cfc6a intotypescript-eslint:masterNov 14, 2021
@JoshuaKGoldbergJoshuaKGoldberg deleted the rule-creator-without-docs branchNovember 14, 2021 22:07
This was referencedNov 16, 2021
This was referencedNov 22, 2021
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuleCreator's types do not support rules without a documentation URL
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp