Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): add playground to website#4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 50 commits intotypescript-eslint:mainfromarmano2:website-playground
Nov 29, 2021

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedNov 8, 2021
edited
Loading

Overview

Migrated version of playground from#3147

Fixes#168

TODO:

  • make it work with latest versions of packages
  • add way to load config instead of drop-down with rules
  • use lzstringto compress code for url
  • add button to generate markdown to copy/paste in tickets
  • in options add dropdown to pick typescript version
  • AST viewer should expand childs when needed
  • add more tsconfig options

fregante reacted with heart emoji
@typescript-eslint

This comment has been minimized.

@netlify
Copy link

netlifybot commentedNov 8, 2021
edited
Loading

✔️ Deploy Preview fortypescript-eslint ready!

🔨 Explore the source changes:e66e0a0

🔍 Inspect the deploy log:https://app.netlify.com/sites/typescript-eslint/deploys/61a4a28da2a6310065ee5260

😎 Browse the preview:https://deploy-preview-4108--typescript-eslint.netlify.app

@nx-cloud

This comment has been minimized.

@armano2armano2 marked this pull request as draftNovember 8, 2021 19:10
@armano2armano2 changed the titlechore(website): migrate playground from #3147chore(website): Add playground to websiteNov 11, 2021
@armano2

This comment has been minimized.

@armano2armano2 added the documentationDocumentation ("docs") that needs adding/updating labelNov 15, 2021
@armano2
Copy link
CollaboratorAuthor

armano2 commentedNov 27, 2021
edited
Loading

The type hint is obstructed by the navbar. (Not sure what to do here, adjustz-index?)

@Josh-Cena fixed

Josh-Cena reacted with thumbs up emoji

@bradzacher
Copy link
Member

one feature request to add to the todo later list for this:

we should add a panel where you can view the "fix" output.
That'd be great as it'd let us repro fix breakages (like#4090) concretely.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if you merge main in then it should fix the linter oom as well

@armano2
Copy link
CollaboratorAuthor

we should add a panel where you can view the "fix" output.
That'd be great as it'd let us repro fix breakages (like#4090) concretely.

added toWebsite Playground (view)

bradzacher reacted with thumbs up emoji

@bradzacher
Copy link
Member

We should talk to / learn from the TS folks with respect to their multi-file playground. I know they added it for their Halloween event and want to enable it more broadly. It'd be good for more complex repros down the line.

(Obv not part of this PR)

armano2 reacted with rocket emoji

@bradzacher
Copy link
Member

Fix up the lint errors and then we can merge this in 😃

armano2 reacted with laugh emoji

@armano2
Copy link
CollaboratorAuthor

Fix up the lint errors and then we can merge this in 😃

fixed

@armano2
Copy link
CollaboratorAuthor

armano2 commentedNov 29, 2021
edited
Loading

not sure why nx is failing here on netlify, looks like its cache issue

@bradzacher any ideas?

@bradzacher
Copy link
Member

https://github.com/armano2/typescript-eslint/blob/website-playground/workspace.json

I think you need to add the package here?

I don't know much about the setup tho. James is the expert with it

@armano2
Copy link
CollaboratorAuthor

armano2 commentedNov 29, 2021
edited
Loading

https://github.com/armano2/typescript-eslint/blob/website-playground/workspace.json

I think you need to add the package here?

I don't know much about the setup tho. James is the expert with it

but@typescript-eslint/website-eslint is already there, hmm

@bradzacher
Copy link
Member

bradzacher commentedNov 29, 2021
edited
Loading

/opt/build/repo/node_modules/@nrwl/workspace/src/utilities/project-graph-utils.js:8    return project.data && project.data.targets && project.data.targets[target];                   ^TypeError: Cannot read properties of undefined (reading 'data')    at Object.projectHasTarget (/opt/build/repo/node_modules/@nrwl/workspace/src/utilities/project-graph-utils.js:8:20)    at addTasksForProjectDependencyConfig (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:168:43)    at addTasksForProjectTarget (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:106:13)    at addTasksForProjectDependencyConfig (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:169:21)    at addTasksForProjectTarget (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:106:13)    at addTasksForProjectDependencyConfig (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:169:21)    at addTasksForProjectTarget (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:106:13)    at addTasksForProjectDependencyConfig (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:169:21)    at addTasksForProjectTarget (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:106:13)    at createTasksForProjectToRun (/opt/build/repo/node_modules/@nrwl/workspace/src/tasks-runner/run-command.js:90:9)

@JamesHenry might have an idea of what's causing the above crash?

@JamesHenry
Copy link
Member

JamesHenry commentedNov 29, 2021
edited
Loading

@bradzacher@armano2 Fixed!

I didn't bother to look into the specific error too deeply because it was occurring when building all projects as part of the postinstall process. That is repeated work for us because we already do that in the GitHub Actions and so I instead figured out how to skip the postinstall within the Netlify build.

I just had to set theYARN_FLAGS environment variable equal to--ignore-scripts and that did the trick.

Thanks so much again for your great work on this@armano2!

Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉

@bradzacherbradzacher changed the titlechore(website): Add playground to websitechore(website): add playground to websiteNov 29, 2021
@bradzacherbradzacher merged commitd72d577 intotypescript-eslint:mainNov 29, 2021
@armano2armano2 deleted the website-playground branchNovember 29, 2021 17:39
@bradzacher
Copy link
Member

I just used this to inspect the AST for TS 4.5 import/export specifier kinds so I could build scope analysis support.
It's truly awesome! astexplorer.net is so far behind (4.1.0 of our package - 1 year old) - so I couldn't use it - but our website is completely up to date!

Such a HUGE win here. I'm so happy you built this with AST support!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees

@armano2armano2

Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive examples / playground
5 participants
@armano2@bradzacher@Josh-Cena@JamesHenry@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp