Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Starting version of website with docs pages and rules#4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedNov 7, 2021
edited
Loading

PR Checklist

Overview

A trimmed down version of@armano2's beautiful#3147, with thewebsite/ directory moved intopackages/ for consistency. Builds off the same branch's Git commit history.

In addition to the tasks already mentioned in#3147, we'll need to follow up on at the very least:

  • Deploying to Netlify
  • Adding back the playground/REPL area
  • Audit language, phrasing, flow, etc. of docs
  • Reworking the rules page, such as improving the h1 and removing previous/next
  • Accessibility/aXe audit
  • Automate callinggenerate-sponsors regularly, such as the waygenerate-contributors is on a cron
  • Fix thewarn Docs markdown link couldn't be resolved: warnings
  • Investigating movingdocs/ files to thepackages/website directory(not sure we want to)

I'd additionally like to file followup tasks for:

  • Search (Algolia?)
  • Adding some kind of easter eggs 😉
  • Creating our own theme to stand out
  • Requiring issues use the playground if possible 💪

Unless directed otherwise I'll probably play with GitHub projects to set all that up.

armano2
armano2 previously requested changesNov 7, 2021
Copy link
Collaborator

@armano2armano2 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

website/src/modules andwebsite/src/vendor should be removed

current compile errors has been solved in#4101

JoshuaKGoldberg reacted with heart emoji
Co-authored-by: Armano <armano2@users.noreply.github.com>
@JoshuaKGoldberg

This comment has been minimized.

@JoshuaKGoldbergJoshuaKGoldberg changed the titleWebsite trimStarting version of website with docs pages and rulesNov 7, 2021
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommaster tofix-babel-7_16-testsNovember 8, 2021 00:02
@codecov
Copy link

codecovbot commentedNov 8, 2021
edited
Loading

Codecov Report

Merging#4099 (0f325fc) intofix-babel-7_16-tests (0cf5ae3) willdecrease coverage by0.38%.
The diff coverage isn/a.

@@                   Coverage Diff                    @@##           fix-babel-7_16-tests    #4099      +/-   ##========================================================- Coverage                 93.11%   92.73%   -0.39%========================================================  Files                       174      334     +160       Lines                      9619    11494    +1875       Branches                   3004     3270     +266     ========================================================+ Hits                       8957    10659    +1702- Misses                      248      362     +114- Partials                    414      473      +59
FlagCoverage Δ
unittest92.73% <ø> (-0.39%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...perimental-utils/src/ts-eslint-scope/Referencer.ts100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.bigint.ts100.00% <0.00%> (ø)
...kages/scope-manager/src/lib/es2017.sharedmemory.ts100.00% <0.00%> (ø)
packages/scope-manager/src/referencer/index.ts100.00% <0.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts50.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2018.promise.ts100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2017.intl.ts100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2019.symbol.ts100.00% <0.00%> (ø)
...-utils/src/ast-utils/eslint-utils/scopeAnalysis.ts100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.symbol.ts100.00% <0.00%> (ø)
... and150 more

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 8, 2021 00:40
@JoshuaKGoldbergJoshuaKGoldberg dismissedarmano2’sstale reviewNovember 8, 2021 00:42

Addressed feedback - would love another review please!

@JamesHenryJamesHenry deleted the branchtypescript-eslint:fix-babel-7_16-testsNovember 8, 2021 14:08
@JoshuaKGoldbergJoshuaKGoldberg deleted the website-trim branchNovember 9, 2021 01:33
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2Awaiting requested review from armano2

@bradzacherbradzacherAwaiting requested review from bradzacher

@JamesHenryJamesHenryAwaiting requested review from JamesHenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation update request
3 participants
@JoshuaKGoldberg@armano2@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp