Thanks for the PR,@ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Nx Cloud Report

CI ran the following commands for commitabb4094. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/visitor-keys

Sent with 💌 fromNxCloud.

That's amazing! This is the thing I wrote in#3735. The only thing that is missing isuse-at-own-risk fromeslint migration. You can cherry-pick from my PR. And I thinknode v10 can be removed fromCI because it is not supported byESLint v8.

I don't think use-at-own-risk can be used unless this plugin drops support for eslint <= v7.

I don't think use-at-own-risk can be used unless this plugin drops support for eslint <= v7.

It's possible for us to use both - it just means we can't migrate to ESM any time soon (not that we were planning on doing that. There's only one module we depend on that's made that switch so far).

This example code should work and allow us to support both, I believe:

import{version}from'eslint';importsemverfrom'semver';constisESLintV8=semver.major(version)>=8;exportfunctiongetESLintCoreRule<RextendsRuleId>(ruleId:R):RuleMap[R]{if(isESLintV8){returnrequire('eslint/use-at-own-risk').builtinRules[ruleId];}else{returnrequire(`eslint/lib/rules/${ruleId}`);}}// for no-loss-of-precisionexportfunctionmaybeGetESLintCoreRule<RextendsRuleId>(ruleId:R):RuleMap[R]|null{try{returngetESLintCoreRule<R>(ruleId);}catch{returnnull;}}

Thank you for the feedback! I changed to the method you suggested.

https://github.com/typescript-eslint/typescript-eslint/pull/3737/files#diff-65ca27a27fffac22b6d171704e8125ad44f370ae4d5b1f92f8d99ba612fa12b1R41

Do you have any ideas on how to fix a lint crash?

What do you think about changing to using eslint v7 in devDependencies and using eslint v8 only for CI unit tests?
This plugin is so popular that I think it could deadlock if you wait for other plugins to be fixed.