Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: remove CLIEngine as it is deprecated and removed from ESLint v8#3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@coderaiser
Copy link
Contributor

Removed deprecated and removed fromESLint v8CLIEngine (#3735)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@coderaiser!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedAug 15, 2021•
edited
Loading

Codecov Report

Merging#3736 (4dbb6a3) intomaster (a602caa) willdecrease coverage by0.10%.
The diff coverage isn/a.

❗ Current head4dbb6a3 differs from pull request most recent headef2014b. Consider uploading reports for the commitef2014b to get more accurate results

@@            Coverage Diff             @@##           master    #3736      +/-   ##==========================================- Coverage   92.68%   92.57%   -0.11%==========================================  Files         327      187     -140       Lines       11351     8477    -2874       Branches     3201     2607     -594     ==========================================- Hits        10521     7848    -2673+ Misses        369      262     -107+ Partials      461      367      -94
FlagCoverage Δ
unittest92.57% <ø> (-0.11%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/experimental-utils/src/ts-eslint/index.ts100.00% <ø> (ø)
packages/scope-manager/src/lib/scripthost.ts
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/lib/esnext.bigint.ts
...ages/scope-manager/src/referencer/ImportVisitor.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/scope-manager/src/lib/es2015.core.ts
...e-manager/src/definition/TSEnumMemberDefinition.ts
packages/scope-manager/src/lib/base-config.ts
packages/scope-manager/src/scope/WithScope.ts
... and130 more

@nx-cloud
Copy link

nx-cloudbot commentedAug 15, 2021•
edited
Loading

@bradzacherbradzacher mentioned this pull requestAug 16, 2021
@bradzacherbradzacher added breaking changeThis change will require a new major version to be released dependenciesIssue about dependencies of the package labelsAug 16, 2021
@bradzacherbradzacher added this to the5.0.0 milestoneAug 16, 2021
@bradzacherbradzacher changed the base branch frommaster tov5August 21, 2021 22:14
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks so much for your work on this!
However we're going to go with#3737 instead as it includes backwards-compatible support.
Until we drop support for ESLint v7 we'll need to remain backwards compatible.

coderaiser reacted with thumbs up emoji
@coderaisercoderaiser deleted the feature/eslint-8-support branchAugust 22, 2021 07:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 22, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher requested changes

Assignees

No one assigned

Labels

breaking changeThis change will require a new major version to be releaseddependenciesIssue about dependencies of the package

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@coderaiser@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp