I realise this isn't the most sophisticated fix (and we can improve this further in the future by adding support for the catch-all builder program as we discussed as part of the long-term solution tocreateDefaultProgram) but for now this at least makes singleRun mode usable with--fix and in my basic testing locally it still yields a speed up over the same invocation without singleRun mode enabled.

Fixes#3626

JamesHenry added bug

Something isn't working

package: typescript-estreeIssues related to @typescript-eslint/typescript-estree labels

Jul 23, 2021

JamesHenry requested review frombradzacher anduniqueiniquity

July 23, 2021 12:26

Copy link

Contributor

typescript-eslintbot commentedJul 23, 2021

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

JamesHenry mentioned this pull request

Jul 23, 2021

[allowAutomaticSingleRunInference] auto fix mangles files#3626

Closed

3 tasks

Copy link

nx-cloudbot commentedJul 23, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commit7393883. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	`nx test @typescript-eslint/eslint-plugin`
	`nx test @typescript-eslint/eslint-plugin-internal`
	`nx test @typescript-eslint/eslint-plugin-tslint`
	`nx test @typescript-eslint/experimental-utils`
	`nx test @typescript-eslint/parser`
	`nx test @typescript-eslint/scope-manager`
	`nx test @typescript-eslint/typescript-estree`
	`nx test @typescript-eslint/visitor-keys`

Sent with 💌 fromNxCloud.

fix(typescript-estree): ensure --fix works with singleRun mode

49c3524

JamesHenry force-pushed thesingle-run-fix-mode branch from86d0703 to49c3524Compare

July 23, 2021 12:56

Copy link

codecovbot commentedJul 23, 2021•
edited
Loading

Codecov Report

Merging#3655 (7393883) intomaster (84fff35) willincrease coverage by0.04%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #3655      +/-   ##==========================================+ Coverage   92.64%   92.68%   +0.04%==========================================  Files         326      325       -1       Lines       11253    11344      +91       Branches     3171     3201      +30     ==========================================+ Hits        10425    10514      +89- Misses        368      369       +1- Partials      460      461       +1

Flag	Coverage Δ
unittest	`92.68% <ø> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/node-utils.ts	`97.83% <0.00%> (ø)`
packages/typescript-estree/src/simple-traverse.ts	`75.00% <0.00%> (ø)`
...es/eslint-plugin/src/rules/no-loss-of-precision.ts	`91.66% <0.00%> (ø)`
...tal-utils/src/ast-utils/eslint-utils/predicates.ts	`100.00% <0.00%> (ø)`
packages/visitor-keys/src/visitor-keys.ts
packages/visitor-keys/src/get-keys.ts
...eslint-plugin/src/rules/prefer-return-this-type.ts	`90.47% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-implied-eval.ts	`93.93% <0.00%> (+0.18%)`	⬆️
...pt-estree/src/create-program/createWatchProgram.ts	`77.27% <0.00%> (+0.23%)`	⬆️
packages/eslint-plugin/src/rules/return-await.ts	`97.02% <0.00%> (+1.15%)`	⬆️
... and6 more