Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(ast-spec): extractAssignmentOperatorToText#3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intotypescript-eslint:mainfromMichaelDeBoey:patch-20
Jun 13, 2022

Conversation

@MichaelDeBoey
Copy link
Contributor

This also makesAssignmentExpression'soperator more type-safe whenever there would be a newAssignmentOperator

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

// @ts-expect-error: purposely unused
type _Test = {
readonly [T in AssignmentOperator]: AssignmentOperatorToText[T];
// If there are any AssignmentOperator members that don't have a corresponding
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same as in#3529

Comment needed to be added afterreadonly line because ofprettier/prettier#11098

@nx-cloud
Copy link

nx-cloudbot commentedJun 21, 2021•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitdf51533. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@bradzacher
Copy link
Member

awaiting updates to#3623

MichaelDeBoey reacted with thumbs up emoji

@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party blocked by another PRPRs which are ready to go but waiting on another PR labelsJul 31, 2021
@MichaelDeBoeyMichaelDeBoeyforce-pushed thepatch-20 branch 5 times, most recently from1184ebf to4d26407CompareAugust 2, 2021 09:07
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelAug 2, 2021
@MichaelDeBoeyMichaelDeBoeyforce-pushed thepatch-20 branch 2 times, most recently from872d436 to8e4c873CompareAugust 21, 2021 17:46
@MichaelDeBoeyMichaelDeBoeyforce-pushed thepatch-20 branch 2 times, most recently from4798a51 to2eed6c5CompareSeptember 8, 2021 08:27
@MichaelDeBoeyMichaelDeBoeyforce-pushed thepatch-20 branch 3 times, most recently from872cc6d to4985516CompareSeptember 22, 2021 10:08
@MichaelDeBoeyMichaelDeBoeyforce-pushed thepatch-20 branch 3 times, most recently from138b4fc toe2707e9CompareOctober 8, 2021 08:19
@MichaelDeBoeyMichaelDeBoey dismissed a stale review via1b7a99eOctober 29, 2021 16:56
@bradzacherbradzacher marked this pull request as draftJanuary 17, 2022 06:27
@netlify
Copy link

netlifybot commentedFeb 1, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitdf51533
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62a68c34dbea3e00090286f1
😎 Deploy Previewhttps://deploy-preview-3570--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedFeb 24, 2022•
edited
Loading

Codecov Report

Merging#3570 (c4bfb07) intomain (b67b6e4) willincrease coverage by0.37%.
The diff coverage isn/a.

❗ Current headc4bfb07 differs from pull request most recent headdf51533. Consider uploading reports for the commitdf51533 to get more accurate results

@@            Coverage Diff             @@##             main    #3570      +/-   ##==========================================+ Coverage   91.33%   91.70%   +0.37%==========================================  Files         132      363     +231       Lines        1488    12205   +10717       Branches      224     3541    +3317     ==========================================+ Hits         1359    11193    +9834- Misses         65      662     +597- Partials       64      350     +286
FlagCoverage Δ
unittest91.70% <ø> (+0.37%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...es/eslint-plugin/src/rules/parameter-properties.ts94.11% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Referencer.ts100.00% <0.00%> (ø)
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts100.00% <0.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts93.19% <0.00%> (ø)
packages/eslint-plugin/src/util/escapeRegExp.ts75.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts100.00% <0.00%> (ø)
...nt-plugin/src/rules/lines-between-class-members.ts92.85% <0.00%> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/util/astUtils.ts83.33% <0.00%> (ø)
... and221 more

@MichaelDeBoey
Copy link
ContributorAuthor

@bradzacher Since#3623 is closed, I guess we can merge this one? 🤔

@bradzacherbradzacher removed the blocked by another PRPRs which are ready to go but waiting on another PR labelMay 18, 2022
bradzacher
bradzacher previously approved these changesJun 13, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks!

MichaelDeBoey reacted with thumbs up emoji
@bradzacherbradzacher changed the titlefix(ast-spec): extractAssignmentOperatorToTextfeat(ast-spec): extractAssignmentOperatorToTextJun 13, 2022
@bradzacherbradzacherenabled auto-merge (squash)June 13, 2022 01:01
@bradzacherbradzacher merged commit45f75e6 intotypescript-eslint:mainJun 13, 2022
@MichaelDeBoeyMichaelDeBoey deleted the patch-20 branchJune 13, 2022 09:46
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelDeBoey@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp