Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): add opt-in inference for single runs and create programs for projects up front#3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 8 commits intomasterfromskip-watch-programs
Jun 11, 2021

Conversation

JamesHenry
Copy link
Member

@JamesHenryJamesHenry commentedJun 9, 2021•
edited by JoshuaKGoldberg
Loading

~10% speed increase when opted into

Screenshot of running yarn lint (49.67s) and TSESTREE_SINGLE_RUN yarn lint (54.61s) in the typescript-eslint repo

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedJun 9, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commit8c7d459. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000nx run-many --target=build --all --parallel
#000000nx run-many --target=typecheck --all --parallel

Sent with 💌 fromNxCloud.

@bradzacherbradzacher added the enhancementNew feature or request labelJun 9, 2021
@codecov
Copy link

codecovbot commentedJun 11, 2021•
edited
Loading

Codecov Report

Merging#3512 (8c7d459) intomaster (79b510c) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #3512   +/-   ##=======================================  Coverage   92.63%   92.63%           =======================================  Files         325      325             Lines       11230    11230             Branches     3165     3165           =======================================  Hits        10403    10403             Misses        367      367             Partials      460      460
FlagCoverage Δ
unittest92.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...t-estree/src/create-program/useProvidedPrograms.ts84.84% <ø> (ø)
...pt-estree/src/create-program/createWatchProgram.ts77.04% <100.00%> (ø)

bradzacher
bradzacher previously approved these changesJun 11, 2021
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code LGTM.
One thought though:

I'm surprised that the type-aware lint rule tests don't break on the CI.
process.env.CI === 'true', meaning the tests should parse with this new logic.

useProvidedPrograms doesn't pass the code from ESLint into the program... so the program is using the code it read from disk.. right?
I don't understand why the tests work!

does jest automatically clear the CI flag...?

…ams.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JamesHenry
Copy link
MemberAuthor

@bradzacher per our slack discussion those existing tests don't have the flag enabled, so there is no change to their behaviour right now

@JamesHenryJamesHenry changed the titlefeat(typescript-estree): detect single run and create programs for projects up frontfeat(typescript-estree): add opt-in inference for single runs and create programs for projects up frontJun 11, 2021
@JamesHenryJamesHenry merged commit06c2d9b intomasterJun 11, 2021
@JamesHenryJamesHenry deleted the skip-watch-programs branchJune 11, 2021 19:44
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JamesHenry@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp