typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore(eslint-plugin): remove lodash from dependencies#3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:masterfromSukkaW:eslint-plugin-remove-lodash

Jun 20, 2021

Merged

chore(eslint-plugin): remove lodash from dependencies#3478

bradzacher merged 1 commit intotypescript-eslint:masterfromSukkaW:eslint-plugin-remove-lodash

Jun 20, 2021

Conversation

Copy link

Contributor

SukkaW commentedJun 2, 2021•
edited
Loading

It is not necessary to add a full lodash as a dependency just for escaping RegExp, right?

Copy link

Contributor

typescript-eslintbot commentedJun 2, 2021

Thanks for the PR,@SukkaW!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

bradzacher linked an issue

Jun 3, 2021

that may beclosed by this pull request

Remove lodash?#2279

Closed

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Jun 3, 2021

bradzacher requested changes

Jun 13, 2021

View reviewed changes

packages/eslint-plugin/src/util/escapeRegExp.tsShow resolvedHide resolved

bradzacher added the awaiting responseIssues waiting for a reply from the OP or another party label

Jun 13, 2021

chore(eslint-plugin): remove lodash from dependencies

80ac539

SukkaW force-pushed theeslint-plugin-remove-lodash branch from38d3d4f to80ac539Compare

June 13, 2021 06:59

MichaelDeBoey approved these changes

Jun 20, 2021

View reviewed changes

Copy link

codecovbot commentedJun 20, 2021

Codecov Report

Merging#3478 (80ac539) intomaster (fc5f171) willdecrease coverage by0.02%.
The diff coverage is83.33%.

@@            Coverage Diff             @@##           master    #3478      +/-   ##==========================================- Coverage   92.66%   92.63%   -0.03%==========================================  Files         324      326       +2       Lines       11188    11240      +52       Branches     3157     3170      +13     ==========================================+ Hits        10367    10412      +45- Misses        365      368       +3- Partials      456      460       +4

Flag	Coverage Δ
unittest	`92.63% <83.33%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/util/escapeRegExp.ts	`80.00% <80.00%> (ø)`
packages/eslint-plugin/src/util/astUtils.ts	`81.81% <100.00%> (ø)`
...ackages/eslint-plugin/src/rules/prefer-includes.ts	`97.87% <0.00%> (-1.03%)`	⬇️
...es/experimental-utils/src/ts-eslint-scope/index.ts	`100.00% <0.00%> (ø)`
...int-plugin/src/rules/prefer-literal-enum-member.ts	`100.00% <0.00%> (ø)`
...ils/src/ast-utils/eslint-utils/ReferenceTracker.ts	`100.00% <0.00%> (ø)`
...t-estree/src/create-program/useProvidedPrograms.ts	`84.84% <0.00%> (ø)`
packages/typescript-estree/src/convert.ts	`98.27% <0.00%> (+<0.01%)`	⬆️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts	`98.30% <0.00%> (+0.05%)`	⬆️
... and2 more