Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: removeTSParenthesizedType#3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sonallux
Copy link
Contributor

This PR removes the legacyTSParenthesizedType AST node. Babel 8 will also stop generating theTSParenthesizedType node (seebabel/babel#12608).

fixes#3136

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sonallux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher added ASTPRs and Issues about the AST structure breaking changeThis change will require a new major version to be released labelsMay 3, 2021
@sonalluxsonalluxforce-pushed the3136-remove-TSParenthesizedType branch fromf11b510 tof66458bCompareMay 10, 2021 14:02
@bradzacherbradzacher added this to the5.0.0 milestoneAug 16, 2021
@bradzacherbradzacher changed the base branch frommaster tov5August 21, 2021 22:14
@bradzacherbradzacher changed the titleRemoveTSParenthesizedTypefeat: removeTSParenthesizedTypeAug 21, 2021
@nx-cloud
Copy link

nx-cloudbot commentedAug 22, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commit326117a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000nx test @typescript-eslint/eslint-plugin-internal
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx run-many --target=typecheck --all --parallel
#000000nx test @typescript-eslint/parser
#000000nx test @typescript-eslint/experimental-utils
#000000nx test @typescript-eslint/scope-manager
#000000nx test @typescript-eslint/visitor-keys
#000000nx test @typescript-eslint/typescript-estree
#000000nx run-many --target=build --all --parallel
#000000nx run-many --target=build --all --parallel
#000000nx run-many --target=build --all --parallel

Sent with 💌 fromNxCloud.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks for your work on this!

@codecov
Copy link

codecovbot commentedAug 22, 2021•
edited
Loading

Codecov Report

Merging#3340 (326117a) intov5 (48858c9) willdecrease coverage by0.21%.
The diff coverage is88.88%.

@@            Coverage Diff             @@##               v5    #3340      +/-   ##==========================================- Coverage   93.42%   93.21%   -0.22%==========================================  Files         147      152       +5       Lines        7804     8014     +210       Branches     2472     2528      +56     ==========================================+ Hits         7291     7470     +179- Misses        176      188      +12- Partials      337      356      +19
FlagCoverage Δ
unittest93.21% <88.88%> (-0.22%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts98.13% <ø> (ø)
packages/eslint-plugin/src/rules/indent.ts92.85% <ø> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/array-type.ts98.61% <83.33%> (+1.27%)⬆️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts90.41% <100.00%> (ø)
.../src/rules/sort-type-union-intersection-members.ts92.53% <100.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts90.00% <0.00%> (ø)
...internal/src/rules/no-typescript-default-import.ts100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts81.75% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts88.88% <0.00%> (ø)
... and1 more

@bradzacherbradzacher merged commit6631ee1 intotypescript-eslint:v5Aug 22, 2021
@sonalluxsonallux deleted the 3136-remove-TSParenthesizedType branchAugust 22, 2021 07:04
bradzacher added a commit that referenced this pull requestSep 3, 2021
fixes#3136Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
bradzacher added a commit that referenced this pull requestSep 21, 2021
fixes#3136Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 22, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

ASTPRs and Issues about the AST structurebreaking changeThis change will require a new major version to be released

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

RemoveTSParenthesizedType

2 participants

@sonallux@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp