Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(eslint-parser): add definition for eslint-scope#33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 4 commits intotypescript-eslint:masterfromarmano2:eslint-scope
Jan 17, 2019
Merged

refactor(eslint-parser): add definition for eslint-scope#33

JamesHenry merged 4 commits intotypescript-eslint:masterfromarmano2:eslint-scope
Jan 17, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJan 16, 2019•
edited
Loading

Not all of types are resolved a lot of properties has type any

@types/estree should be replaced with definition fromtypescript-estree, but i didn't finish it yet there

@codecov
Copy link

codecovbot commentedJan 17, 2019•
edited
Loading

Codecov Report

Merging#33 intomaster willnot change coverage.
The diff coverage is100%.

Impacted file tree graph

@@           Coverage Diff           @@##           master      #33   +/-   ##=======================================  Coverage   93.77%   93.77%           =======================================  Files          11       11             Lines        1686     1686             Branches      376      376           =======================================  Hits         1581     1581             Misses         55       55             Partials       50       50
Impacted FilesCoverage Δ
...ages/typescript-eslint-parser/src/analyze-scope.ts93.25% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1dcb159...518f439. Read thecomment docs.

JamesHenry
JamesHenry previously approved these changesJan 17, 2019
@armano2
Copy link
CollaboratorAuthor

i'm still working on this :>

@armano2
Copy link
CollaboratorAuthor

armano2 commentedJan 17, 2019•
edited
Loading

ok its finished

@JamesHenryJamesHenry merged commitebe638b intotypescript-eslint:masterJan 17, 2019
@armano2armano2 deleted the eslint-scope branchJanuary 17, 2019 01:09
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp