Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): remove legacyuseJSXTextNode option#3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 6 commits intov5fromfeat/drop-jsx-tag-node
Aug 22, 2021

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 24, 2021•
edited
Loading

This change removes legacy option for useJSXTag names and enable it always.
This option was present to support use case of eslint 5

This change is related to#2683

https://astexplorer.net/#/gist/80c278121e6b7a6984ef08d730040240/7d48b11779b51084a3457ae301011e1a69ae50ef
https://github.com/facebook/jsx

@armano2armano2 added package: typescript-estreeIssues related to @typescript-eslint/typescript-estree breaking changeThis change will require a new major version to be released labelsFeb 24, 2021
@armano2armano2 added this to the5.0.0 milestoneFeb 24, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@armano2armano2 changed the titlefeat(typescript-estree): remove legacy useJSXTextNode optionfeat(typescript-estree): remove legacy useJSXTextNode option used by eslint 5Feb 24, 2021
@bradzacherbradzacher changed the base branch frommaster tov5August 21, 2021 22:16
# Conflicts:#packages/typescript-estree/src/convert.ts#packages/typescript-estree/src/parser-options.ts#packages/typescript-estree/src/parser.ts
@nx-cloud
Copy link

nx-cloudbot commentedAug 22, 2021•
edited
Loading

Nx Cloud Report

CI ran the following commands for commitac4f6bd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-internal
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/parser
#000000nx test @typescript-eslint/experimental-utils
#000000nx test @typescript-eslint/scope-manager
#000000nx test @typescript-eslint/visitor-keys
#000000nx test @typescript-eslint/typescript-estree
#000000nx run-many --target=build --all --parallel
#000000nx test @typescript-eslint/parser
#000000nx test @typescript-eslint/experimental-utils
#000000nx test @typescript-eslint/scope-manager
#000000nx test @typescript-eslint/visitor-keys
#000000nx test @typescript-eslint/typescript-estree

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedAug 22, 2021•
edited
Loading

Codecov Report

Merging#3109 (ac4f6bd) intov5 (48858c9) willdecrease coverage by0.19%.
The diff coverage isn/a.

@@            Coverage Diff             @@##               v5    #3109      +/-   ##==========================================- Coverage   93.42%   93.22%   -0.20%==========================================  Files         147      154       +7       Lines        7804     8063     +259       Branches     2472     2538      +66     ==========================================+ Hits         7291     7517     +226- Misses        176      188      +12- Partials      337      358      +21
FlagCoverage Δ
unittest93.22% <ø> (-0.20%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts88.88% <0.00%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts97.36% <0.00%> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts100.00% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts90.00% <0.00%> (ø)
...internal/src/rules/no-typescript-default-import.ts100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts81.75% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts87.50% <0.00%> (ø)

@bradzacherbradzacher changed the titlefeat(typescript-estree): remove legacy useJSXTextNode option used by eslint 5feat(typescript-estree): remove legacyuseJSXTextNode optionAug 22, 2021
@bradzacherbradzacher merged commite80056f intov5Aug 22, 2021
@bradzacherbradzacher deleted the feat/drop-jsx-tag-node branchAugust 22, 2021 02:22
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 22, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releasedpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp