Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(typescript-estree): simplify applyModifiersToResult#3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 1 commit intomasterfromrefactor/apply-modifers
Feb 21, 2021

Conversation

@armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 21, 2021•
edited
Loading

Those changes has been extracted from#3078

simplifies logic used to generate deprecatedmodifiers field in some of nodes. instead of iterating over nodes collecting results, filtering them and mapping them again we perform entire operation in first loop

this change has negligible perf improvement

@armano2armano2 added package: typescript-estreeIssues related to @typescript-eslint/typescript-estree refactorPRs that refactor code only labelsFeb 21, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedFeb 21, 2021•
edited
Loading

Codecov Report

Merging#3084 (81dfe13) intomaster (763a252) willdecrease coverage by0.00%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #3084      +/-   ##==========================================- Coverage   92.83%   92.83%   -0.01%==========================================  Files         314      314                Lines       10675    10671       -4       Branches     3027     3027              ==========================================- Hits         9910     9906       -4  Misses        348      348                Partials      417      417
FlagCoverage Δ
unittest92.83% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts98.36% <100.00%> (-0.01%)⬇️

@armano2armano2 merged commit0469102 intomasterFeb 21, 2021
@armano2armano2 deleted the refactor/apply-modifers branchFebruary 21, 2021 23:34
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

package: typescript-estreeIssues related to @typescript-eslint/typescript-estreerefactorPRs that refactor code only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp