typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(typescript-estree): correct issues in AST definition#3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

armano2 merged 6 commits intomasterfromfix/ast-structure

Feb 22, 2021

Merged

fix(typescript-estree): correct issues in AST definition#3083

armano2 merged 6 commits intomasterfromfix/ast-structure

Feb 22, 2021

Conversation

Copy link

Collaborator

armano2 commentedFeb 21, 2021•
edited
Loading

Those changes has been extracted from#3078

fixes#2912

`ProgramStatement` and`Statement` nodes can contain same set of nodes

if(x)export{x}if(x)importtestfrom'x'// -----for(xinfoo){export{x}}// -----functiontest(x:string){export{x}}

`LeftHandSideExpression` can be a`AwaitExpression`

consta=++(awaitx)

`TryStatement` finalizer can be`null`

try{}catch{}

`RegExpLiteral` value can be`null` if regexp is invalid or unsupported by env

good example in this case can be any proposal that has not been accepted yet
eg.https://github.com/tc39/proposal-regexp-match-indices

constx=/a+(?<Z>z)?/d

`JSXOpeningElement` attributes can be a`JSXSpreadAttribute`

constfoo=<x{...spread}></x>

`TSModuleDeclaration` body can be`TSModuleDeclaration`

// TSModuleDeclaration without bodymodule"x";// TSModuleDeclaration -> TSModuleBlockmodulex{}// TSModuleDeclaration -> TSModuleDeclaration **modulex.x{}

fix: correct issues in AST definition

fe74a6f

Copy link

Contributor

typescript-eslintbot commentedFeb 21, 2021

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

armano2 added AST

PRs and Issues about the AST structure

bugSomething isn't working labels

Feb 21, 2021

fix: add missing type check to no-unused-vars

34b9d6a

armano2 force-pushed thefix/ast-structure branch from1121cd7 to34b9d6aCompare

February 21, 2021 15:05

Copy link

codecovbot commentedFeb 21, 2021•
edited
Loading

Codecov Report

Merging#3083 (ac64fe0) intomaster (409bf0b) willincrease coverage by0.00%.
The diff coverage is90.90%.

@@           Coverage Diff           @@##           master    #3083   +/-   ##=======================================  Coverage   92.83%   92.83%           =======================================  Files         314      314             Lines       10671    10672    +1       Branches     3027     3027           =======================================+ Hits         9906     9907    +1  Misses        348      348             Partials      417      417