Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create TSTypeQuery node when TSImportType has isTypeOf#3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 6 commits intov6fromfeat/ts-import-type
Oct 26, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 19, 2021•
edited by bradzacher
Loading

BREAKING CHANGE:
Changes AST structure in a backwards-incompatible way

fixes#2998

@armano2armano2 added breaking changeThis change will require a new major version to be released ASTPRs and Issues about the AST structure labelsFeb 19, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@armano2armano2 changed the titlefeat: update TSImportType nodefeat: create TSTypeQuery node when TSImportType has isTypeOfFeb 19, 2021
parameter: this.convertChild(node.argument),
argument: this.convertChild(node.argument),
Copy link
CollaboratorAuthor

@armano2armano2Feb 19, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i renamed this property from parameter to argument as is more aligned with typescript/babel and rest of types

eg, call expression hasarguments

JoshuaKGoldberg reacted with thumbs up emoji
@codecov
Copy link

codecovbot commentedFeb 19, 2021•
edited
Loading

Codecov Report

Merging#3076 (059d912) intomaster (5e2a993) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #3076   +/-   ##=======================================  Coverage   92.87%   92.88%           =======================================  Files         314      314             Lines       10670    10679    +9       Branches     3026     3029    +3     =======================================+ Hits         9910     9919    +9  Misses        344      344             Partials      416      416
FlagCoverage Δ
unittest92.88% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
...ckages/scope-manager/src/referencer/TypeVisitor.ts94.79% <100.00%> (+0.11%)⬆️
packages/typescript-estree/src/convert.ts98.38% <100.00%> (+0.01%)⬆️

@armano2armano2 added package: scope-managerIssues related to @typescript-eslint/scope-manager package: typescript-estreeIssues related to @typescript-eslint/typescript-estree and removed package: scope-managerIssues related to @typescript-eslint/scope-manager package: typescript-estreeIssues related to @typescript-eslint/typescript-estree labelsFeb 19, 2021
@armano2armano2 marked this pull request as ready for reviewFebruary 19, 2021 19:51
@armano2armano2 added this to the5.0.0 milestoneFeb 20, 2021
@bradzacherbradzacher changed the base branch frommaster tov5August 21, 2021 22:16
@bradzacherbradzacher modified the milestones:5.0.0,6.0.0Oct 11, 2021
Base automatically changed fromv5 tomasterOctober 11, 2021 17:55
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJan 23, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

I'm not high enough confidence in AST dealings to merge myself, so I'll defer to@bradzacher

@bradzacher
Copy link
Member

yeah this is sound - just needs to wait for the next major

JoshuaKGoldberg reacted with thumbs up emoji

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJan 24, 2022
JoshuaKGoldbergand others added4 commitsOctober 25, 2022 15:22
…nd parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@JoshuaKGoldbergJoshuaKGoldberg dismissed stale reviews fromghost and themself via0e6bcedOctober 26, 2022 00:27
@nx-cloud
Copy link

nx-cloudbot commentedOct 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0e6bced. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedOct 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0e6bced
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63587f1121070f000963d707
😎 Deploy Previewhttps://deploy-preview-3076--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6October 26, 2022 00:40
@JoshuaKGoldbergJoshuaKGoldberg deleted the feat/ts-import-type branchOctober 26, 2022 00:42
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeASTPRs and Issues about the AST structurebreaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[RFC] AST structure of TSImportType to be more align with rest of AST
4 participants
@armano2@bradzacher@JoshuaKGoldberg@adnanhashmi09
[8]ページ先頭
©2009-2025 Movatter.jp