feat: add stable PrivateIdentifier based on estree spec#2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

armano2 wants to merge3 commits intov5fromfix-private-identifier

Closed

feat: add stable PrivateIdentifier based on estree spec#2933

armano2 wants to merge3 commits intov5fromfix-private-identifier

Conversation

Copy link

Collaborator

armano2 commentedJan 12, 2021•
edited by bradzacher
Loading

Add stable PrivateIdentifier ts-estree base on estree spec,

Due to lack of spec this field field was read as is from typescript,

Changes to produced AST:

value field got renamed toname without initial#

TODO:

add unit tests fornaming-convention rule
add unit tests forno-unsafe-assignment rule

fixes#1436
ref#3430

estree spec:https://github.com/estree/estree/blob/master/experimental/class-features.md

This comment has been minimized.

armano2 added the ASTPRs and Issues about the AST structure label

Jan 12, 2021

Copy link

codecovbot commentedJan 12, 2021•
edited
Loading

Codecov Report

Merging#2933 (b249029) intov5 (763a252) willdecrease coverage by0.00%.
The diff coverage is87.50%.

@@            Coverage Diff             @@##               v5    #2933      +/-   ##==========================================- Coverage   92.83%   92.82%   -0.01%==========================================  Files         314      314                Lines       10675    10680       +5       Branches     3027     3031       +4     ==========================================+ Hits         9910     9914       +4  Misses        348      348- Partials      417      418       +1

Flag	Coverage Δ
unittest	`92.82% <87.50%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts	`92.43% <0.00%> (-0.79%)`	⬇️
packages/eslint-plugin/src/rules/prefer-for-of.ts	`90.14% <ø> (ø)`
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	`100.00% <ø> (ø)`
packages/visitor-keys/src/visitor-keys.ts	`100.00% <ø> (ø)`
...gin/src/rules/naming-convention-utils/validator.ts	`94.44% <100.00%> (+0.03%)`	⬆️
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.28% <100.00%> (+0.09%)`	⬆️
packages/eslint-plugin/src/util/misc.ts	`92.85% <100.00%> (+0.26%)`	⬆️
packages/typescript-estree/src/convert.ts	`98.38% <100.00%> (+<0.01%)`	⬆️

armano2 changed the title~~feat: add stable PrivateIdentifier base on estree spec~~feat: add stable PrivateIdentifier based on estree spec

Jan 12, 2021

bradzacher added the enhancementNew feature or request label

Jan 13, 2021

Copy link

Member

bradzacher commentedJan 13, 2021

Based on my discussion with them inestree/estree#240 - I'm happy for us to add these to the AST.
I'd like to wait until we move them from the experimental folder to be 100% certain nothing is going to change (it shouldn't, but better safe than sorry!)
I'll probs raise a PR there on the weekend.

bradzacher marked this pull request as draft

January 13, 2021 07:10

armano2 added breaking changeThis change will require a new major version to be released and removed breaking changeThis change will require a new major version to be released labels

Feb 6, 2021