Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): support eslint@5#2917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@SimenB! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
| @@ -46,6 +46,7 @@ | |||
| "@typescript-eslint/scope-manager": "4.12.0", | |||
| "debug": "^4.1.1", | |||
| "functional-red-black-tree": "^1.0.1", | |||
| "lodash": "^4.17.15", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@typescript-eslint/eslint-plugin-tslint and@typescript-eslint/typescript-estree already depend on it, so shouldn't make a difference
| : str || ''; | ||
| } | ||
| function getNameLocationInGlobalDirectiveComment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
my IDE "complained" about duplicate code, so I found this and just removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for doing this!
Codecov Report
@@ Coverage Diff @@## master #2917 +/- ##==========================================+ Coverage 92.76% 92.77% +0.01%========================================== Files 311 311 Lines 10460 10456 -4 Branches 2957 2954 -3 ==========================================- Hits 9703 9701 -2 Misses 348 348+ Partials 409 407 -2
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Fixes#2890