Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add rulesort-type-union-intersection-members#2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomasterfromunion-intersection-sorting
Jan 4, 2021

Conversation

@bradzacher
Copy link
Member

@bradzacherbradzacher commentedJan 3, 2021•
edited
Loading

Pretty straightforward.
For#2911 I was annoyed at having to remember to manually sort every union type.
And going forwards I'd like to validate that they're sorted.

Sorting is great because it makes it super simple to manually verify there's no duplicate types, and it reduces diff churn.

dimitropoulos reacted with hooray emoji
@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelJan 3, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedJan 3, 2021•
edited
Loading

Codecov Report

Merging#2913 (fdd94d6) intomaster (4d69fbb) willdecrease coverage by0.00%.
The diff coverage is92.30%.

@@            Coverage Diff             @@##           master    #2913      +/-   ##==========================================- Coverage   92.76%   92.76%   -0.01%==========================================  Files         310      311       +1       Lines       10395    10460      +65       Branches     2944     2957      +13     ==========================================+ Hits         9643     9703      +60- Misses        347      348       +1- Partials      405      409       +4
FlagCoverage Δ
unittest92.76% <92.30%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/configs/all.ts100.00% <ø> (ø)
.../src/rules/sort-type-union-intersection-members.ts92.30% <92.30%> (ø)

@bradzacherbradzacherforce-pushed theunion-intersection-sorting branch 2 times, most recently fromc14ebb3 toab8195cCompareJanuary 3, 2021 20:33
@bradzacherbradzacherforce-pushed theunion-intersection-sorting branch fromab8195c to56232c8CompareJanuary 4, 2021 00:07
@bradzacherbradzacher merged commit9092c04 intomasterJan 4, 2021
@bradzacherbradzacher deleted the union-intersection-sorting branchJanuary 4, 2021 01:12
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 4, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement: new plugin ruleNew rule request for eslint-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp