typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(ts-estree): make sure that every node can be converted to tsNode#287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

armano2 merged 10 commits intotypescript-eslint:masterfromarmano2:fix-export

Feb 19, 2019

Merged

fix(ts-estree): make sure that every node can be converted to tsNode#287

armano2 merged 10 commits intotypescript-eslint:masterfromarmano2:fix-export

Feb 19, 2019

Conversation

Copy link

Collaborator

armano2 commentedFeb 15, 2019

This PR makes sure that all nodes can be converted into ts.Node and fixes crash inpromise-function-async rule

fixes:#227

armano2 added5 commits

February 15, 2019 00:10

fix(ts-estree): improve types in fix export

02a3137

fix(ts-estree): fix issue with registering in maps exported nodes

533c03c

fix(ts-estree): register node to tsNodeToESTreeNodeMap only once

e6cfa76

fix(eslint-plugin): fix crash in promise-function-async

bbc4b21

fix(ts-estree): make sure that every node can be translated to tsNode

cbb9858

armano2 requested a review frombradzacher

February 15, 2019 00:26

Copy link

codecovbot commentedFeb 15, 2019•
edited
Loading

Codecov Report

Merging#287 intomaster willdecrease coverage by0.07%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #287      +/-   ##==========================================- Coverage   95.03%   94.96%   -0.08%==========================================  Files          67       67                Lines        2801     2801                Branches      724      724              ==========================================- Hits         2662     2660       -2  Misses         53       53- Partials       86       88       +2

Impacted Files	Coverage Δ
packages/typescript-estree/src/node-utils.ts	`96.62% <ø> (-0.23%)`	⬇️
packages/typescript-estree/src/convert.ts	`98.23% <100%> (+0.02%)`	⬆️
.../eslint-plugin/src/rules/promise-function-async.ts	`100% <100%> (ø)`	⬆️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts	`90.9% <0%> (-3.64%)`	⬇️

armano2 added3 commits

February 15, 2019 01:33

chore(ts-estree): add missing function description

1867b9d

test(ts-estree): add test case for esTreeNodeToTSNodeMap

c4cd0af

chore(ts-estree): fix code formatting

69970f7

armano2 requested a review fromJamesHenry

February 15, 2019 01:00

armano2 marked this pull request as ready for review

February 15, 2019 01:00

Copy link

CollaboratorAuthor

armano2 commentedFeb 15, 2019•
edited
Loading

no-unnecessary-qualifier can be now simplified

'ExportNamedDeclaration[declaration.type="TSModuleDeclaration"]':enterDeclaration,'ExportNamedDeclaration[declaration.type="TSEnumDeclaration"]':enterDeclaration,'ExportNamedDeclaration[declaration.type="TSModuleDeclaration"]:exit':exitDeclaration,'ExportNamedDeclaration[declaration.type="TSEnumDeclaration"]:exit':exitDeclaration,

is no longer needed

and ifs