Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [naming-convention] add modifierunused#2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomasterfromnaming-convention-unused
Nov 24, 2020

Conversation

bradzacher
Copy link
Member

Fixes#1510

Leverages the infra added in#2768 to mark variables as unused

glen-84 reacted with hooray emoji
@bradzacherbradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labelNov 24, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedNov 24, 2020•
edited
Loading

Codecov Report

Merging#2810 (87f42b5) intomaster (fb254a1) willincrease coverage by0.02%.
The diff coverage is95.23%.

@@            Coverage Diff             @@##           master    #2810      +/-   ##==========================================+ Coverage   92.71%   92.74%   +0.02%==========================================  Files         301      301                Lines       10191    10232      +41       Branches     2889     2902      +13     ==========================================+ Hits         9449     9490      +41+ Misses        345      344       -1- Partials      397      398       +1
FlagCoverage Δ
unittest92.74% <95.23%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts88.91% <95.23%> (+0.47%)⬆️
...ackages/scope-manager/src/referencer/Referencer.ts94.87% <0.00%> (+0.84%)⬆️

Fixes#1510Leverages the infra added in#2768 to mark variables as unused
@bradzacherbradzacher merged commit6a06944 intomasterNov 24, 2020
@bradzacherbradzacher deleted the naming-convention-unused branchNovember 24, 2020 21:27
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 25, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naming-convention] Allow underscore prefix for unused parameters
1 participant
@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp