Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(eslint-plugin): remove support for eslint 5#2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

thomasmichaelwallace
Copy link
Contributor

Resolves#2465

As far as I understood the issue, you don't think this is a breaking change (what with v5 being very old).

Following the issue I compared against eslint 6.8 (latest) to see what messageIds weren't set then, so as to avoid regressing#2451.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@thomasmichaelwallace!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacher
Copy link
Member

Thanks for doing this!

I didn't label it as such, but it is a breaking change - any change in the supported dependencies is a breaking change (even if peopleshould have upgraded their deps by now).
We can leave this on ice until we are ready for the next major.

thomasmichaelwallace reacted with thumbs up emoji

@bradzacherbradzacher added this to the5.0.0 milestoneOct 16, 2020
@bradzacherbradzacher added breaking changeThis change will require a new major version to be released dependenciesIssue about dependencies of the package labelsOct 16, 2020
@thomasmichaelwallace
Copy link
ContributorAuthor

No worries - I did suspect as much. Feel free to@thomasmichaelwallace me when the time comes for v5, I'd be happy to tackle any issues updating the branch for merge.

It'd be awesome if you could label the PRshacktoberfest-accepted in the interim. (Sorry to ask, it's annoying they put this on the maintainers; if it's a hassle, it's not a problem.)

bradzacher reacted with thumbs up emoji

@armano2
Copy link
Collaborator

armano2 commentedFeb 8, 2021
edited
Loading

we should also look at changes done in#2917 and most likely some of them can be removed, that could potentially partially fix#2279

bradzacher, thomasmichaelwallace, and hehex9 reacted with thumbs up emoji

@nx-cloud
Copy link

nx-cloudbot commentedAug 22, 2021
edited
Loading

Nx Cloud Report

CI ran the following commands for commit6c2803b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

StatusCommand
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx test @typescript-eslint/eslint-plugin-internal
#000000nx test @typescript-eslint/eslint-plugin-tslint
#000000nx test @typescript-eslint/eslint-plugin
#000000nx run-many --target=typecheck --all --parallel
#000000nx test @typescript-eslint/parser
#000000nx test @typescript-eslint/experimental-utils
#000000nx test @typescript-eslint/scope-manager
#000000nx test @typescript-eslint/visitor-keys
#000000nx test @typescript-eslint/typescript-estree
#000000nx run-many --target=build --all --parallel
#000000nx run-many --target=build --all --parallel
#000000nx test @typescript-eslint/parser

Sent with 💌 fromNxCloud.

@bradzacher
Copy link
Member

Unfortunately with eslint v8 they hid all of their utils - so we can't leverage them - so we're stuck with the changes from#2917

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for this! we can finally merge this in :)

thomasmichaelwallace reacted with hooray emoji
@bradzacherbradzacher merged commit207a231 intotypescript-eslint:v5Aug 22, 2021
@thomasmichaelwallacethomasmichaelwallace deleted the issue-2465 branchAugust 22, 2021 21:55
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 22, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releaseddependenciesIssue about dependencies of the packagehacktoberfest-accepted
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Drop support for ESLint v5
3 participants
@thomasmichaelwallace@bradzacher@armano2

[8]ページ先頭

©2009-2025 Movatter.jp