Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(typescript-estree): add flag EXPERIMENTAL_useSourceOfProjectReferenceRedirect#2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bradzacher merged 3 commits intomasterfromEXPERIMENTAL_useSourceOfProjectReferenceRedirectOct 15, 2020
Merged
feat(typescript-estree): add flag EXPERIMENTAL_useSourceOfProjectReferenceRedirect#2669
bradzacher merged 3 commits intomasterfromEXPERIMENTAL_useSourceOfProjectReferenceRedirectOct 15, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…renceRedirectSee#2094This is quick-and-dirty to get this out there for some users to see what sort of perf improvements this squeezes out.With the flag turned on:```bradzacher@bradzacher-mbp typescript-eslint % DEBUG=typescript-eslint:* yarn eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.tsyarn run v1.22.4$ /Users/bradzacher/github/typescript-eslint/node_modules/.bin/eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [ './tsconfig.eslint.json', './tests/integration/utils/jsconfig.json', './packages/eslint-plugin/tsconfig.json', './packages/eslint-plugin-internal/tsconfig.json', './packages/eslint-plugin-tslint/tsconfig.json', './packages/experimental-utils/tsconfig.json', './packages/parser/tsconfig.json', './packages/scope-manager/tsconfig.json', './packages/shared-fixtures/tsconfig.json', './packages/types/tsconfig.json', './packages/typescript-estree/tsconfig.json', './packages/visitor-keys/tsconfig.json'] +0ms typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms typescript-eslint:typescript-estree:createWatchProgram File did not belong to any existing programs, moving to create/update. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tsconfig.eslint.json. +0ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tests/integration/utils/jsconfig.json. +1s typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/tsconfig.json. +844ms typescript-eslint:typescript-estree:createWatchProgram Found program for file. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +2s typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +0ms typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [ './tsconfig.eslint.json', './tests/integration/utils/jsconfig.json', './packages/eslint-plugin/tsconfig.json', './packages/eslint-plugin-internal/tsconfig.json', './packages/eslint-plugin-tslint/tsconfig.json', './packages/experimental-utils/tsconfig.json', './packages/parser/tsconfig.json', './packages/scope-manager/tsconfig.json', './packages/shared-fixtures/tsconfig.json', './packages/types/tsconfig.json', './packages/typescript-estree/tsconfig.json', './packages/visitor-keys/tsconfig.json'] +5s typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +5s typescript-eslint:typescript-estree:createWatchProgram Found existing program for file. /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +74ms typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +70ms✨ Done in 6.50s.```With the flag turned off:```bradzacher@bradzacher-mbp typescript-eslint % DEBUG=typescript-eslint:* yarn eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.tsyarn run v1.22.4$ /Users/bradzacher/github/typescript-eslint/node_modules/.bin/eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [ './tsconfig.eslint.json', './tests/integration/utils/jsconfig.json', './packages/eslint-plugin/tsconfig.json', './packages/eslint-plugin-internal/tsconfig.json', './packages/eslint-plugin-tslint/tsconfig.json', './packages/experimental-utils/tsconfig.json', './packages/parser/tsconfig.json', './packages/scope-manager/tsconfig.json', './packages/shared-fixtures/tsconfig.json', './packages/types/tsconfig.json', './packages/typescript-estree/tsconfig.json', './packages/visitor-keys/tsconfig.json'] +0ms typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms typescript-eslint:typescript-estree:createWatchProgram File did not belong to any existing programs, moving to create/update. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tsconfig.eslint.json. +1ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tests/integration/utils/jsconfig.json. +1s typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/tsconfig.json. +976ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin-internal/tsconfig.json. +2s typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin-tslint/tsconfig.json. +1s typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/experimental-utils/tsconfig.json. +1s typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/parser/tsconfig.json. +961ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/scope-manager/tsconfig.json. +888ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/shared-fixtures/tsconfig.json. +996ms typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/types/tsconfig.json. +561ms typescript-eslint:typescript-estree:createWatchProgram Found program for file. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +567ms typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +0ms typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [ './tsconfig.eslint.json', './tests/integration/utils/jsconfig.json', './packages/eslint-plugin/tsconfig.json', './packages/eslint-plugin-internal/tsconfig.json', './packages/eslint-plugin-tslint/tsconfig.json', './packages/experimental-utils/tsconfig.json', './packages/parser/tsconfig.json', './packages/scope-manager/tsconfig.json', './packages/shared-fixtures/tsconfig.json', './packages/types/tsconfig.json', './packages/typescript-estree/tsconfig.json', './packages/visitor-keys/tsconfig.json'] +11s typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +11s typescript-eslint:typescript-estree:createWatchProgram Found existing program for file. /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +64ms typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +60ms✨ Done in 12.26s.```
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
codecovbot commentedOct 12, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2669 +/- ##==========================================- Coverage 92.83% 92.78% -0.05%========================================== Files 294 294 Lines 9666 9676 +10 Branches 2711 2713 +2 ==========================================+ Hits 8973 8978 +5- Misses 327 330 +3- Partials 366 368 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
See#2094
This is quick-and-dirty to get this out there for some users to see what sort of perf improvements this squeezes out.
Intentionally not documenting the flag as it isn't ready to be used by the wider world
With the flag turned on
With the flag turned off
Comparisons:
With the flag turned on, runtime is ~6s.
With the flag turned off, runtime is ~12s.
With the flag turned on, we're able to find
./packages/types/src/index.tswithin theeslint-pluginprogram and exit early.With the flag turned off, we have to iterate and calculate almost all of the programs to find the program for
typescript-estree(because our config is alphabetically sorted).Important note that I just found out -
projectsare not carried through tsconfigextends!To test this I had to duplicate the project references config between from the build tsconfigs into the dev tsconfigs.
Kind of annoying but w/e 🤷♂️