fix(eslint-plugin): handle missing message IDs in eslint v5/v6#2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 5 commits intotypescript-eslint:masterfromesetnik:no-unused-vars-eslint-v6

Sep 1, 2020

Merged

fix(eslint-plugin): handle missing message IDs in eslint v5/v6#2461

bradzacher merged 5 commits intotypescript-eslint:masterfromesetnik:no-unused-vars-eslint-v6

Sep 1, 2020

Conversation

Copy link

Contributor

esetnik commentedSep 1, 2020

Fixes#2451

esetnik added2 commits

September 1, 2020 09:44

fix(eslint-plugin): no-unused-vars

f7cd051

add eslint v6 messages

f52849a

Copy link

Contributor

typescript-eslintbot commentedSep 1, 2020

Thanks for the PR,@esetnik!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

prettier

0d2f0ae

esetnik marked this pull request as ready for review

September 1, 2020 14:13

Copy link

codecovbot commentedSep 1, 2020•
edited
Loading

Codecov Report

Merging#2461 intomaster willdecrease coverage by0.11%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##           master    #2461      +/-   ##==========================================- Coverage   92.94%   92.83%   -0.12%==========================================  Files         289      289                Lines        9272     9283      +11       Branches     2583     2594      +11     ==========================================  Hits         8618     8618                Misses        320      320- Partials      334      345      +11

Flag	Coverage Δ
#unittest	`92.83% <0.00%> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/indent.ts	`90.47% <0.00%> (-2.21%)`	⬇️
...kages/eslint-plugin/src/rules/init-declarations.ts	`76.47% <0.00%> (-4.78%)`	⬇️
...ackages/eslint-plugin/src/rules/keyword-spacing.ts	`92.85% <0.00%> (-7.15%)`	⬇️
...nt-plugin/src/rules/lines-between-class-members.ts	`85.71% <0.00%> (-6.60%)`	⬇️
...ackages/eslint-plugin/src/rules/no-invalid-this.ts	`95.45% <0.00%> (-4.55%)`	⬇️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts	`80.76% <0.00%> (-1.59%)`	⬇️
...s/eslint-plugin/src/rules/no-unused-expressions.ts	`88.88% <0.00%> (-5.23%)`	⬇️
packages/eslint-plugin/src/rules/no-unused-vars.ts	`95.38% <0.00%> (-1.50%)`	⬇️
.../eslint-plugin/src/rules/no-useless-constructor.ts	`95.23% <0.00%> (-4.77%)`	⬇️
packages/eslint-plugin/src/rules/quotes.ts	`88.88% <0.00%> (-5.23%)`	⬇️
... and1 more