Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript-estree): switch to globby#2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intov4fromswitch-to-globby
Aug 24, 2020
Merged

Conversation

@bradzacher
Copy link
Member

@bradzacherbradzacher commentedAug 23, 2020
edited
Loading

Fixes#2398

If the user has a particularly large node_modules folder and uses globs forparserOption.project, then theglob library can spend a decent chunk of time searching thenode_modules folder.
In some cases, this can be on the order of hundreds to thousands of milliseconds.
This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted).
Over a whole project, this can easily add up to many, many seconds wasted.

Previously, we:

  • applied the project globs, one by one
  • then manually excludedtsconfigs from the list.

This meant that we are always slow. I remember I did this because I had issues gettingglob'signore option to work at all.

The solution

globby is a better glob library:

  • it accepts an array of globs, which saves us doing manual looping
  • it supports exclusion globs (globs prefixed with!), which are evaluated as part of the glob process
  • it has caching built in by default

This allows us to evaluate all of theproject globs at once, as opposed to one at a time (so should be less duplicated work).
This also allows us to evaluate theprojectFolderIgnoreList at the same time as theproject globs (so should be no useless work done).

All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching).
For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file.

Example to illustrate how much faster this can potentially be:
For a project that provides 2project globs and has 100 files.
Before:300ms * 2 projects * 100 files = 60,000ms (60s)
After:50ms + 2ms * 100 files = 250ms

This should also save a non-trival amount of time in other, more optimal setups.

BREAKING CHANGE:

  • removes the ability to supply aRegExp toprojectFolderIgnoreList, and changes the meaning of the string value from a regex to a glob.

brody4hire and alansongzoom reacted with hooray emojimaneetgoyal and alansongzoom reacted with heart emoji
@bradzacherbradzacher added bugSomething isn't working breaking changeThis change will require a new major version to be released labelsAug 23, 2020
@bradzacherbradzacher added this to the4.0.0 milestoneAug 23, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher linked an issueAug 23, 2020 that may beclosed by this pull request
Fixes#2398If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder.In some cases, this can be on the order of hundreds to thousands of milliseconds.This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted).Over a whole project, this can easily add up to many, many seconds wasted.Previously, we:- applied the project globs, one by one- then manually excluded `tsconfig`s from the list.This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all.## The solution`globby` is a better glob library:- it accepts an array of globs, which saves us doing manual looping- it supports exclusion globs (globs prefixed with `!`), which  are evaluated as part of the glob process- it has caching built in by defaultThis allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work).This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done).All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching).For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file.Example to illustrate how much faster this can potentially be:For a project that provides 2 globs and has 100 files.Before: 300ms * 2 * 100 = 60,000ms (60s)After: 50ms + 2 * 100 = 250msThis should also save a non-trival amount of time in other, more optimal setups.BREAKING CHANGE:- removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
@bradzacherbradzacher merged commit789c439 intov4Aug 24, 2020
@bradzacherbradzacher deleted the switch-to-globby branchAugust 24, 2020 02:11
bradzacher added a commit that referenced this pull requestAug 29, 2020
Fixes#2398If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder.In some cases, this can be on the order of hundreds to thousands of milliseconds.This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted).Over a whole project, this can easily add up to many, many seconds wasted.Previously, we:- applied the project globs, one by one- then manually excluded `tsconfig`s from the list.This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all.## The solution`globby` is a better glob library:- it accepts an array of globs, which saves us doing manual looping- it supports exclusion globs (globs prefixed with `!`), which  are evaluated as part of the glob process- it has caching built in by defaultThis allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work).This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done).All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching).For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file.Example to illustrate how much faster this can potentially be:For a project that provides 2 globs and has 100 files.Before: 300ms * 2 * 100 = 60,000ms (60s)After: 50ms + 2 * 100 = 250msThis should also save a non-trival amount of time in other, more optimal setups.BREAKING CHANGE:- removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
bradzacher added a commit that referenced this pull requestAug 29, 2020
Fixes#2398If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder.In some cases, this can be on the order of hundreds to thousands of milliseconds.This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted).Over a whole project, this can easily add up to many, many seconds wasted.Previously, we:- applied the project globs, one by one- then manually excluded `tsconfig`s from the list.This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all.## The solution`globby` is a better glob library:- it accepts an array of globs, which saves us doing manual looping- it supports exclusion globs (globs prefixed with `!`), which  are evaluated as part of the glob process- it has caching built in by defaultThis allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work).This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done).All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching).For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file.Example to illustrate how much faster this can potentially be:For a project that provides 2 globs and has 100 files.Before: 300ms * 2 * 100 = 60,000ms (60s)After: 50ms + 2 * 100 = 250msThis should also save a non-trival amount of time in other, more optimal setups.BREAKING CHANGE:- removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 24, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking changeThis change will require a new major version to be releasedbugSomething isn't working

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Slow createProjectProgram/createWatchProgram

2 participants

@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp