Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
test(eslint-plugin): add test cases for eslint rules#240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
4 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletionspackages/eslint-plugin/tests/RuleTester.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
250 changes: 246 additions & 4 deletionspackages/eslint-plugin/tests/eslint-rules/no-redeclare.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,55 @@ | ||
| import rule from 'eslint/lib/rules/no-redeclare'; | ||
| import { AST_NODE_TYPES } from '@typescript-eslint/typescript-estree'; | ||
| import { RuleTester } from '../RuleTester'; | ||
| const ruleTester = new RuleTester({ | ||
| parserOptions: { | ||
| ecmaVersion: 6 | ||
| }, | ||
| parser: '@typescript-eslint/parser' | ||
| }); | ||
| ruleTester.run('no-redeclare', rule, { | ||
| valid: [ | ||
| 'var a = 3; var b = function() { var a = 10; };', | ||
| 'var a = 3; a = 10;', | ||
| { | ||
| code: 'if (true) {\n let b = 2;\n} else { \nlet b = 3;\n}', | ||
| parserOptions: { | ||
| ecmaVersion: 6 | ||
| } | ||
| }, | ||
| 'var Object = 0;', | ||
| { code: 'var Object = 0;', options: [{ builtinGlobals: false }] }, | ||
| { | ||
| code: 'var Object = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { sourceType: 'module' } | ||
| }, | ||
| { | ||
| code: 'var Object = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { ecmaFeatures: { globalReturn: true } } | ||
| }, | ||
| { code: 'var top = 0;', env: { browser: true } }, | ||
| { code: 'var top = 0;', options: [{ builtinGlobals: true }] }, | ||
| { | ||
| code: 'var top = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { ecmaFeatures: { globalReturn: true } }, | ||
| env: { browser: true } | ||
| }, | ||
| { | ||
| code: 'var top = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { sourceType: 'module' }, | ||
| env: { browser: true } | ||
| }, | ||
| { | ||
| code: 'var self = 1', | ||
| options: [{ builtinGlobals: true }], | ||
| env: { browser: false } | ||
| }, | ||
| // https://github.com/eslint/typescript-eslint-parser/issues/443 | ||
| ` | ||
| const Foo = 1; | ||
| @@ -22,7 +60,211 @@ type Foo = 1; | ||
| function foo({ bar }: { bar: string }) { | ||
| console.log(bar); | ||
| } | ||
| `, | ||
| ` | ||
| type AST<T extends ParserOptions> = TSESTree.Program & | ||
| (T['range'] extends true ? { range: [number, number] } : {}) & | ||
| (T['tokens'] extends true ? { tokens: TSESTree.Token[] } : {}) & | ||
| (T['comment'] extends true ? { comments: TSESTree.Comment[] } : {}); | ||
| interface ParseAndGenerateServicesResult<T extends ParserOptions> { | ||
| ast: AST<T>; | ||
| services: ParserServices; | ||
| } | ||
| `, | ||
| ` | ||
| function A<T>() {} | ||
| interface B<T> {} | ||
| type C<T> = Array<T> | ||
| class D<T> {} | ||
| ` | ||
| ], | ||
| invalid: [ | ||
| { | ||
| code: 'var a = 3; var a = 10;', | ||
| parserOptions: { ecmaVersion: 6 }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. ugh, we should consider PRing the base eslint to migrate their rules to messageId There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. yup we should :) | ||
| ] | ||
| }, | ||
| { | ||
| code: 'switch(foo) { case a: var b = 3;\ncase b: var b = 4}', | ||
| errors: [ | ||
| { | ||
| message: "'b' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a = 3; var a = 10;', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a = {}; var a = [];', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a; function a() {}', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'function a() {} function a() {}', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a = function() { }; var a = function() { }', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a = function() { }; var a = new Date();', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a = 3; var a = 10; var a = 15;', | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any, | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a; var a;', | ||
| parserOptions: { sourceType: 'module' }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'export var a; var a;', | ||
| parserOptions: { sourceType: 'module' }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var Object = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| errors: [ | ||
| { | ||
| message: "'Object' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var top = 0;', | ||
| options: [{ builtinGlobals: true }], | ||
| errors: [ | ||
| { | ||
| message: "'top' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ], | ||
| env: { browser: true } | ||
| }, | ||
| { | ||
| code: 'var a; var {a = 0, b: Object = 0} = {};', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { ecmaVersion: 6 }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any, | ||
| { | ||
| message: "'Object' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a; var {a = 0, b: Object = 0} = {};', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { ecmaVersion: 6, sourceType: 'module' }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a; var {a = 0, b: Object = 0} = {};', | ||
| options: [{ builtinGlobals: true }], | ||
| parserOptions: { ecmaVersion: 6, ecmaFeatures: { globalReturn: true } }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| { | ||
| code: 'var a; var {a = 0, b: Object = 0} = {};', | ||
| options: [{ builtinGlobals: false }], | ||
| parserOptions: { ecmaVersion: 6 }, | ||
| errors: [ | ||
| { | ||
| message: "'a' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| }, | ||
| // Notifications of readonly are moved from no-undef: https://github.com/eslint/eslint/issues/4504 | ||
| { | ||
| code: '/*global b:false*/ var b = 1;', | ||
| options: [{ builtinGlobals: true }], | ||
| errors: [ | ||
| { | ||
| message: "'b' is already defined.", | ||
| type: AST_NODE_TYPES.Identifier | ||
| } as any | ||
| ] | ||
| } | ||
| ] | ||
| }); | ||
31 changes: 0 additions & 31 deletionspackages/eslint-plugin/tests/eslint-rules/no-use-before-define.test.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
19 changes: 17 additions & 2 deletionspackages/eslint-plugin/tests/rules/no-use-before-define.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.